Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1303153003: Change Counter to be a CSSValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase & removed dependent patchsets Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSValue.cpp ('k') | Source/core/css/Counter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * Copyright (C) 2015 Google Inc. All rights reserved. 7 * Copyright (C) 2015 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public 10 * modify it under the terms of the GNU Lesser General Public
(...skipping 11 matching lines...) Expand all
22 * 02110-1301 USA 22 * 02110-1301 USA
23 */ 23 */
24 24
25 #include "config.h" 25 #include "config.h"
26 #include "core/css/ComputedStyleCSSValueMapping.h" 26 #include "core/css/ComputedStyleCSSValueMapping.h"
27 27
28 #include "core/StylePropertyShorthand.h" 28 #include "core/StylePropertyShorthand.h"
29 #include "core/css/BasicShapeFunctions.h" 29 #include "core/css/BasicShapeFunctions.h"
30 #include "core/css/CSSBorderImage.h" 30 #include "core/css/CSSBorderImage.h"
31 #include "core/css/CSSBorderImageSliceValue.h" 31 #include "core/css/CSSBorderImageSliceValue.h"
32 #include "core/css/CSSCounterValue.h"
32 #include "core/css/CSSFontFeatureValue.h" 33 #include "core/css/CSSFontFeatureValue.h"
33 #include "core/css/CSSFunctionValue.h" 34 #include "core/css/CSSFunctionValue.h"
34 #include "core/css/CSSGridLineNamesValue.h" 35 #include "core/css/CSSGridLineNamesValue.h"
35 #include "core/css/CSSGridTemplateAreasValue.h" 36 #include "core/css/CSSGridTemplateAreasValue.h"
36 #include "core/css/CSSPathValue.h" 37 #include "core/css/CSSPathValue.h"
37 #include "core/css/CSSPrimitiveValueMappings.h" 38 #include "core/css/CSSPrimitiveValueMappings.h"
38 #include "core/css/CSSReflectValue.h" 39 #include "core/css/CSSReflectValue.h"
39 #include "core/css/CSSShadowValue.h" 40 #include "core/css/CSSShadowValue.h"
40 #include "core/css/CSSTimingFunctionValue.h" 41 #include "core/css/CSSTimingFunctionValue.h"
41 #include "core/css/CSSValueList.h" 42 #include "core/css/CSSValueList.h"
42 #include "core/css/CSSValuePool.h" 43 #include "core/css/CSSValuePool.h"
43 #include "core/css/Counter.h"
44 #include "core/css/Pair.h" 44 #include "core/css/Pair.h"
45 #include "core/css/Rect.h" 45 #include "core/css/Rect.h"
46 #include "core/layout/LayoutBlock.h" 46 #include "core/layout/LayoutBlock.h"
47 #include "core/layout/LayoutBox.h" 47 #include "core/layout/LayoutBox.h"
48 #include "core/layout/LayoutGrid.h" 48 #include "core/layout/LayoutGrid.h"
49 #include "core/layout/LayoutObject.h" 49 #include "core/layout/LayoutObject.h"
50 #include "core/style/ComputedStyle.h" 50 #include "core/style/ComputedStyle.h"
51 #include "core/style/ContentData.h" 51 #include "core/style/ContentData.h"
52 #include "core/style/PathStyleMotionPath.h" 52 #include "core/style/PathStyleMotionPath.h"
53 #include "core/style/QuotesData.h" 53 #include "core/style/QuotesData.h"
(...skipping 947 matching lines...) Expand 10 before | Expand all | Expand 10 after
1001 for (const ContentData* contentData = style.contentData(); contentData; cont entData = contentData->next()) { 1001 for (const ContentData* contentData = style.contentData(); contentData; cont entData = contentData->next()) {
1002 if (contentData->isCounter()) { 1002 if (contentData->isCounter()) {
1003 const CounterContent* counter = toCounterContentData(contentData)->c ounter(); 1003 const CounterContent* counter = toCounterContentData(contentData)->c ounter();
1004 ASSERT(counter); 1004 ASSERT(counter);
1005 RefPtrWillBeRawPtr<CSSPrimitiveValue> identifier = cssValuePool().cr eateValue(counter->identifier(), CSSPrimitiveValue::UnitType::CustomIdentifier); 1005 RefPtrWillBeRawPtr<CSSPrimitiveValue> identifier = cssValuePool().cr eateValue(counter->identifier(), CSSPrimitiveValue::UnitType::CustomIdentifier);
1006 RefPtrWillBeRawPtr<CSSPrimitiveValue> separator = cssValuePool().cre ateValue(counter->separator(), CSSPrimitiveValue::UnitType::CustomIdentifier); 1006 RefPtrWillBeRawPtr<CSSPrimitiveValue> separator = cssValuePool().cre ateValue(counter->separator(), CSSPrimitiveValue::UnitType::CustomIdentifier);
1007 CSSValueID listStyleIdent = CSSValueNone; 1007 CSSValueID listStyleIdent = CSSValueNone;
1008 if (counter->listStyle() != NoneListStyle) 1008 if (counter->listStyle() != NoneListStyle)
1009 listStyleIdent = static_cast<CSSValueID>(CSSValueDisc + counter- >listStyle()); 1009 listStyleIdent = static_cast<CSSValueID>(CSSValueDisc + counter- >listStyle());
1010 RefPtrWillBeRawPtr<CSSPrimitiveValue> listStyle = cssValuePool().cre ateIdentifierValue(listStyleIdent); 1010 RefPtrWillBeRawPtr<CSSPrimitiveValue> listStyle = cssValuePool().cre ateIdentifierValue(listStyleIdent);
1011 list->append(cssValuePool().createValue(Counter::create(identifier.r elease(), listStyle.release(), separator.release()))); 1011 list->append(CSSCounterValue::create(identifier.release(), listStyle .release(), separator.release()));
1012 } else if (contentData->isImage()) { 1012 } else if (contentData->isImage()) {
1013 const StyleImage* image = toImageContentData(contentData)->image(); 1013 const StyleImage* image = toImageContentData(contentData)->image();
1014 ASSERT(image); 1014 ASSERT(image);
1015 list->append(image->cssValue()); 1015 list->append(image->cssValue());
1016 } else if (contentData->isText()) { 1016 } else if (contentData->isText()) {
1017 list->append(cssValuePool().createValue(toTextContentData(contentDat a)->text(), CSSPrimitiveValue::UnitType::String)); 1017 list->append(cssValuePool().createValue(toTextContentData(contentDat a)->text(), CSSPrimitiveValue::UnitType::String));
1018 } else if (contentData->isQuote()) { 1018 } else if (contentData->isQuote()) {
1019 const QuoteType quoteType = toQuoteContentData(contentData)->quote() ; 1019 const QuoteType quoteType = toQuoteContentData(contentData)->quote() ;
1020 list->append(cssValuePool().createIdentifierValue(valueForQuoteType( quoteType))); 1020 list->append(cssValuePool().createIdentifierValue(valueForQuoteType( quoteType)));
1021 } else { 1021 } else {
(...skipping 1667 matching lines...) Expand 10 before | Expand all | Expand 10 after
2689 case CSSPropertyAll: 2689 case CSSPropertyAll:
2690 return nullptr; 2690 return nullptr;
2691 default: 2691 default:
2692 break; 2692 break;
2693 } 2693 }
2694 ASSERT_NOT_REACHED(); 2694 ASSERT_NOT_REACHED();
2695 return nullptr; 2695 return nullptr;
2696 } 2696 }
2697 2697
2698 } 2698 }
OLDNEW
« no previous file with comments | « Source/core/css/CSSValue.cpp ('k') | Source/core/css/Counter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698