Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304993002: Change Rect and Quad to be CSSValues (Closed)

Created:
5 years, 4 months ago by sashab
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@split_counter_out_attempt_3
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change Rect and Quad to be CSSValues Change Rect and Quad to be CSSQuadValue, and remove rects and quads from CSSPrimitiveValue. BUG=523893 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201293

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed Rect.h and added empty destructor declaration back #

Patch Set 3 : Removed empty destructor #

Total comments: 13

Patch Set 4 : Review feedback #

Total comments: 1

Patch Set 5 : Rebase #

Patch Set 6 : Added empty Rect.h file #

Patch Set 7 : Removed empty Rect.h file #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase onto master #

Patch Set 10 : Small change to generated style builder functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -399 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 4 chunks +12 lines, -17 lines 0 comments Download
M Source/core/animation/ImageSliceStyleInterpolation.cpp View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 1 2 3 5 chunks +31 lines, -26 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolationTest.cpp View 1 2 3 3 chunks +56 lines, -63 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 7 chunks +0 lines, -13 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 7 chunks +0 lines, -45 lines 0 comments Download
A Source/core/css/CSSQuadValue.h View 1 2 3 1 chunk +83 lines, -0 lines 0 comments Download
A Source/core/css/CSSQuadValue.cpp View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 2 3 4 5 6 7 8 6 chunks +14 lines, -0 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 5 6 7 8 4 chunks +9 lines, -22 lines 0 comments Download
M Source/core/css/Rect.h View 1 6 1 chunk +0 lines, -124 lines 0 comments Download
D Source/core/css/Rect.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 7 8 17 chunks +26 lines, -38 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1317523002 Patch 20001
Issue 1317523002 Patch 30001
Issue 1317523002 Patch 50001

Messages

Total messages: 51 (23 generated)
sashab
5 years, 4 months ago (2015-08-21 07:28:26 UTC) #2
esprehn
Is there a bug to track what you're doing here? :) https://codereview.chromium.org/1304993002/diff/1/Source/core/css/Rect.h File Source/core/css/Rect.h (right): ...
5 years, 4 months ago (2015-08-21 09:57:15 UTC) #3
sashab
https://codereview.chromium.org/1304993002/diff/1/Source/core/css/Rect.h File Source/core/css/Rect.h (right): https://codereview.chromium.org/1304993002/diff/1/Source/core/css/Rect.h#newcode33 Source/core/css/Rect.h:33: class CORE_EXPORT CSSQuadValue : public CSSValue { On 2015/08/21 ...
5 years, 4 months ago (2015-08-24 01:56:59 UTC) #4
Timothy Loh
+alancutter for my comment on LengthBoxStyleInterpolation https://codereview.chromium.org/1304993002/diff/40001/Source/core/animation/LengthBoxStyleInterpolation.cpp File Source/core/animation/LengthBoxStyleInterpolation.cpp (right): https://codereview.chromium.org/1304993002/diff/40001/Source/core/animation/LengthBoxStyleInterpolation.cpp#newcode26 Source/core/animation/LengthBoxStyleInterpolation.cpp:26: bool startRect = ...
5 years, 4 months ago (2015-08-24 03:18:04 UTC) #5
sashab
https://codereview.chromium.org/1304993002/diff/40001/Source/core/animation/LengthBoxStyleInterpolation.cpp File Source/core/animation/LengthBoxStyleInterpolation.cpp (right): https://codereview.chromium.org/1304993002/diff/40001/Source/core/animation/LengthBoxStyleInterpolation.cpp#newcode26 Source/core/animation/LengthBoxStyleInterpolation.cpp:26: bool startRect = start.isQuadValue() && toCSSQuadValue(start).isRect(); On 2015/08/24 03:18:04, ...
5 years, 4 months ago (2015-08-24 05:43:58 UTC) #6
alancutter (OOO until 2018)
Animation code lgtm. https://codereview.chromium.org/1304993002/diff/40001/Source/core/animation/LengthBoxStyleInterpolation.cpp File Source/core/animation/LengthBoxStyleInterpolation.cpp (right): https://codereview.chromium.org/1304993002/diff/40001/Source/core/animation/LengthBoxStyleInterpolation.cpp#newcode26 Source/core/animation/LengthBoxStyleInterpolation.cpp:26: bool startRect = start.isQuadValue() && toCSSQuadValue(start).isRect(); ...
5 years, 4 months ago (2015-08-24 06:27:44 UTC) #8
Timothy Loh
lgtm https://codereview.chromium.org/1304993002/diff/60001/Source/core/css/Rect.h File Source/core/css/Rect.h (left): https://codereview.chromium.org/1304993002/diff/60001/Source/core/css/Rect.h#oldcode1 Source/core/css/Rect.h:1: /* not sure if you actually deleted this ...
5 years, 4 months ago (2015-08-24 06:41:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/120001
5 years, 4 months ago (2015-08-25 01:00:39 UTC) #12
sashab
It says Rect.h is deleted in the raw patchset, so it should be OK.
5 years, 4 months ago (2015-08-25 01:00:40 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/60813) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-25 01:02:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/120001
5 years, 4 months ago (2015-08-25 03:22:46 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/102940)
5 years, 4 months ago (2015-08-25 03:25:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/140001
5 years, 4 months ago (2015-08-25 04:02:59 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/94516)
5 years, 4 months ago (2015-08-25 04:43:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/140001
5 years, 4 months ago (2015-08-25 04:45:32 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/54311)
5 years, 4 months ago (2015-08-25 04:58:15 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/140001
5 years, 4 months ago (2015-08-25 05:05:57 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95022)
5 years, 4 months ago (2015-08-25 05:09:15 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/140001
5 years, 4 months ago (2015-08-25 06:55:55 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95069)
5 years, 4 months ago (2015-08-25 07:38:21 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/140001
5 years, 3 months ago (2015-08-26 00:55:06 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/95061)
5 years, 3 months ago (2015-08-26 01:40:08 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/140001
5 years, 3 months ago (2015-08-26 01:44:05 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/103541)
5 years, 3 months ago (2015-08-26 02:01:00 UTC) #45
sashab
Tim, I found a small bug -- fixed in the StyleBuilder template, 1-line change ptal.
5 years, 3 months ago (2015-08-27 05:29:58 UTC) #46
Timothy Loh
On 2015/08/27 05:29:58, sashab wrote: > Tim, I found a small bug -- fixed in ...
5 years, 3 months ago (2015-08-27 05:31:48 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304993002/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304993002/170001
5 years, 3 months ago (2015-08-27 05:33:59 UTC) #50
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 07:19:06 UTC) #51
Message was sent while issue was closed. 
Committed patchset #10 (id:170001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201293

Powered by Google App Engine
This is Rietveld 408576698