Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1302233003: Replace gmock's deprecated SetArgumentPointee with SetArgPointee. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, chromoting-reviews_chromium.org, zea+watch_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, maxbogue+watch_chromium.org, piman+watch_chromium.org, dkrahn+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, oshima+watch_chromium.org, tfarina, noyau+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace gmock's deprecated SetArgumentPointee with SetArgPointee. BUG=630705 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=blundell@chromium.org,jrummell@chromium.org,kelvinp@chromium.org,piman@chromium.org Review-Url: https://codereview.chromium.org/1302233003 Cr-Commit-Position: refs/heads/master@{#469611} Committed: https://chromium.googlesource.com/chromium/src/+/e147d68dc40b1470b6de6c2d8f9232bd788e897e

Patch Set 1 #

Patch Set 2 : 2017 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -377 lines) Patch
M base/gmock_unittest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M base/nix/xdg_util_unittest.cc View 1 13 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization/customization_document_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 1 10 chunks +12 lines, -12 lines 0 comments Download
M components/browser_sync/profile_sync_service_typed_url_unittest.cc View 1 22 chunks +37 lines, -48 lines 0 comments Download
M components/search_engines/search_engine_data_type_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/async_directory_type_controller_unittest.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M components/sync/driver/frontend_data_type_controller_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M components/sync_bookmarks/bookmark_data_type_controller_unittest.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 5 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/command_executor_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 9 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 1 3 chunks +18 lines, -24 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_lost.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 9 chunks +11 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 1 16 chunks +53 lines, -62 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 15 chunks +65 lines, -77 lines 0 comments Download
M media/audio/alsa/alsa_output_unittest.cc View 1 15 chunks +29 lines, -41 lines 0 comments Download
M media/audio/cras/cras_unified_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_glue_unittest.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
pwnall
LGTM. Consider running this through some bots with DCHECK on -- googletest 1.8.0's gmock had ...
3 years, 7 months ago (2017-05-05 06:20:40 UTC) #6
Lei Zhang
On 2017/05/05 06:20:40, pwnall wrote: > LGTM. > > Consider running this through some bots ...
3 years, 7 months ago (2017-05-05 06:31:25 UTC) #7
Lei Zhang
TBRing OWNERS for directories I don't own. This CL is just a search and replace, ...
3 years, 7 months ago (2017-05-05 06:37:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1302233003/20001
3 years, 7 months ago (2017-05-05 07:27:13 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 07:32:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e147d68dc40b1470b6de6c2d8f92...

Powered by Google App Engine
This is Rietveld 408576698