chrome/browser/safe_browsing/client_side_detection_host_unittest.cc - Issue 1302233003: Replace gmock's deprecated SetArgumentPointee with SetArgPointee.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 1302233003: Replace gmock's deprecated SetArgumentPointee with SetArgPointee. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2017 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

index 7460413f210acee588bcd859208cf3f624355b8b..92453f04ed34ea4dfb3abc036cdd1976f8a7858d 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

@@ -47,7 +47,7 @@ using ::testing::NotNull;

using ::testing::Pointee;

using ::testing::Return;

using ::testing::SaveArg;

-using ::testing::SetArgumentPointee;

+using ::testing::SetArgPointee;

using ::testing::StrictMock;

using content::BrowserThread;

using content::RenderFrameHostTester;

@@ -284,8 +284,8 @@ class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {

}

if (get_valid_cached_result) {

EXPECT_CALL(*csd_service_, GetValidCachedResult(url, NotNull()))

- .WillOnce(DoAll(SetArgumentPointee<1>(true),

- Return(*get_valid_cached_result)));

+ .WillOnce(

+ DoAll(SetArgPointee<1>(true), Return(*get_valid_cached_result)));

}

if (is_in_cache) {

EXPECT_CALL(*csd_service_, IsInCache(url)).WillOnce(Return(*is_in_cache));