Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301523003: added emitChild() to GrGLFragmentProcessor; removed AutoFragmentChildProcAdvance class (Closed)

Created:
5 years, 4 months ago by wangyix
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@cs3_glinstances2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

added emitChild() to GrGLFragmentProcessor; removed AutoFragmentChildProcAdvance class BUG=skia:4182 Committed: https://skia.googlesource.com/skia/+/2a378433ebd16cd0dc034d291dea2983b82378e2

Patch Set 1 #

Patch Set 2 : changed emitted comment before child's emitted code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -113 lines) Patch
M src/gpu/gl/GrGLFragmentProcessor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.cpp View 2 chunks +80 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +0 lines, -31 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +0 lines, -82 lines 0 comments Download

Depends on Patchset:

Issue 1287023009 Patch 120001

Dependent Patchsets:

Issue 1298233002 Patch 1

Messages

Total messages: 8 (3 generated)
wangyix
I just moved the stuff that was in the constructor and destructor of the AutoFragmentChildProcAdvance ...
5 years, 4 months ago (2015-08-18 14:49:50 UTC) #2
tomhudson
lgtm
5 years, 4 months ago (2015-08-18 14:55:28 UTC) #3
bsalomon
On 2015/08/18 14:55:28, tomhudson wrote: > lgtm lgtm too
5 years, 4 months ago (2015-08-18 14:57:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301523003/20001
5 years, 4 months ago (2015-08-18 18:50:37 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 19:00:14 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2a378433ebd16cd0dc034d291dea2983b82378e2

Powered by Google App Engine
This is Rietveld 408576698