Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 1298233002: Added fNumTransformsExclChildren and fNumTexturesExclChildren; changed emitChild() to forward search (Closed)

Created:
5 years, 4 months ago by wangyix
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@cs3_emitchild
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

This change is in preparation for updating how processor keys and meta keys are generated for frag procs. BUG=skia:4182 Committed: https://skia.googlesource.com/skia/+/93ab254b7e4ce82074e88e219a8e32b31086ca86

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -19 lines) Patch
M include/gpu/GrFragmentProcessor.h View 5 chunks +14 lines, -2 lines 2 comments Download
M include/gpu/GrProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.cpp View 2 chunks +13 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
wangyix
5 years, 4 months ago (2015-08-18 19:21:57 UTC) #2
tomhudson
lgtm https://codereview.chromium.org/1298233002/diff/1/include/gpu/GrFragmentProcessor.h File include/gpu/GrFragmentProcessor.h (right): https://codereview.chromium.org/1298233002/diff/1/include/gpu/GrFragmentProcessor.h#newcode45 include/gpu/GrFragmentProcessor.h:45: int numTexturesExclChildren() const { return fNumTexturesExclChildren; } nit: ...
5 years, 4 months ago (2015-08-18 19:36:11 UTC) #3
joshualitt
On 2015/08/18 19:36:11, tomhudson wrote: > lgtm > > https://codereview.chromium.org/1298233002/diff/1/include/gpu/GrFragmentProcessor.h > File include/gpu/GrFragmentProcessor.h (right): > ...
5 years, 4 months ago (2015-08-19 13:34:28 UTC) #4
bsalomon
lgtm, but I'm liking the bubbling up less as we go along. Might rather have ...
5 years, 4 months ago (2015-08-19 14:22:17 UTC) #5
wangyix
On 2015/08/19 14:22:17, bsalomon wrote: > lgtm, but I'm liking the bubbling up less as ...
5 years, 4 months ago (2015-08-19 15:04:35 UTC) #6
joshualitt
On 2015/08/19 15:04:35, wangyix wrote: > On 2015/08/19 14:22:17, bsalomon wrote: > > lgtm, but ...
5 years, 4 months ago (2015-08-19 15:04:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298233002/1
5 years, 4 months ago (2015-08-19 15:06:42 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 15:23:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/93ab254b7e4ce82074e88e219a8e32b31086ca86

Powered by Google App Engine
This is Rietveld 408576698