Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301073003: Merge to XFA: Extern in .cpp files is a code smell, part 1. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Extern in .cpp files is a code smell, part 1. (cherry picked from commit 71c15a5e6652952a94ba3a3ef7ac0392e3a06962) Original Review URL: https://codereview.chromium.org/1299963002 . R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7da980351d6fc428fd95be3015081d911f4470c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -72 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +10 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +2 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M core/src/fpdftext/unicodenormalization.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
A core/src/fpdftext/unicodenormalizationdata.h View 1 chunk +18 lines, -0 lines 0 comments Download
M core/src/fpdftext/unicodenormalizationdata.cpp View 5 chunks +11 lines, -5 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixed.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixedBoldItalic.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSans.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerif.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifBold.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifBoldItalic.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifItalic.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifMM.c View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSymbol.c View 1 chunk +2 lines, -0 lines 0 comments Download
A core/src/fxge/fontdata/chromefontdata/chromefontdata.h View 1 chunk +35 lines, -0 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +1 line, -18 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +8 lines, -9 lines 0 comments Download
M pdfium.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR, automatic merge.
5 years, 4 months ago (2015-08-19 17:34:28 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-19 17:41:19 UTC) #2
Tom Sepez
5 years, 4 months ago (2015-08-19 17:42:49 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7da980351d6fc428fd95be3015081d911f4470c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698