fpdfsdk/src/fpdf_dataavail.cpp - Issue 1301073003: Merge to XFA: Extern in .cpp files is a code smell, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_dataavail.cpp

Issue 1301073003: Merge to XFA: Extern in .cpp files is a code smell, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdf_dataavail.cpp

diff --git a/fpdfsdk/src/fpdf_dataavail.cpp b/fpdfsdk/src/fpdf_dataavail.cpp

index b9cf69d647341ce90fbee7ded074e33c36be4840..663e166b0310985cd1dc584938410ea53dcd008e 100644

--- a/fpdfsdk/src/fpdf_dataavail.cpp

+++ b/fpdfsdk/src/fpdf_dataavail.cpp

@@ -98,8 +98,6 @@ DLLEXPORT int STDCALL FPDFAvail_IsDocAvail(FPDF_AVAIL avail,

return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsDocAvail(&hints_wrap);

}

-extern void CheckUnSupportError(CPDF_Document* pDoc, FX_DWORD err_code);

DLLEXPORT FPDF_DOCUMENT STDCALL

FPDFAvail_GetDocument(FPDF_AVAIL avail, FPDF_BYTESTRING password) {

if (avail == NULL)

« no previous file with comments | « fpdfsdk/include/fsdk_define.h ('k') | fpdfsdk/src/fpdftext.cpp » ('j') | no next file with comments »