Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: fpdfsdk/src/fpdftext.cpp

Issue 1301073003: Merge to XFA: Extern in .cpp files is a code smell, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/fpdf_dataavail.cpp ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../core/include/fpdfdoc/fpdf_doc.h" 7 #include "../../core/include/fpdfdoc/fpdf_doc.h"
8 #include "../../core/include/fpdftext/fpdf_text.h" 8 #include "../../core/include/fpdftext/fpdf_text.h"
9 #include "../../public/fpdf_text.h" 9 #include "../../public/fpdf_text.h"
10 #include "../include/fpdfxfa/fpdfxfa_doc.h" 10 #include "../include/fpdfxfa/fpdfxfa_doc.h"
11 #include "../include/fpdfxfa/fpdfxfa_page.h" 11 #include "../include/fpdfxfa/fpdfxfa_page.h"
12 12
13 #ifdef _WIN32 13 #ifdef _WIN32
14 #include <tchar.h> 14 #include <tchar.h>
15 #endif 15 #endif
16 16
17 // jabdelmalek: commented out to build on Linux. Not used.
18 // extern HANDLE g_hModule;
19
20 DLLEXPORT FPDF_TEXTPAGE STDCALL FPDFText_LoadPage(FPDF_PAGE page) { 17 DLLEXPORT FPDF_TEXTPAGE STDCALL FPDFText_LoadPage(FPDF_PAGE page) {
21 if (!page) 18 if (!page)
22 return NULL; 19 return NULL;
23 IPDF_TextPage* textpage = NULL; 20 IPDF_TextPage* textpage = NULL;
24 CPDFXFA_Page* pPage = (CPDFXFA_Page*)page; 21 CPDFXFA_Page* pPage = (CPDFXFA_Page*)page;
25 if (!pPage->GetPDFPage()) 22 if (!pPage->GetPDFPage())
26 return NULL; 23 return NULL;
27 CPDFXFA_Document* pDoc = pPage->GetDocument(); 24 CPDFXFA_Document* pDoc = pPage->GetDocument();
28 CPDF_ViewerPreferences viewRef(pDoc->GetPDFDoc()); 25 CPDF_ViewerPreferences viewRef(pDoc->GetPDFDoc());
29 textpage = IPDF_TextPage::CreateTextPage((CPDF_Page*)pPage->GetPDFPage(), 26 textpage = IPDF_TextPage::CreateTextPage((CPDF_Page*)pPage->GetPDFPage(),
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 CFX_FloatRect rect = rectArray.GetAt(rect_index); 282 CFX_FloatRect rect = rectArray.GetAt(rect_index);
286 *left = rect.left; 283 *left = rect.left;
287 *right = rect.right; 284 *right = rect.right;
288 *top = rect.top; 285 *top = rect.top;
289 *bottom = rect.bottom; 286 *bottom = rect.bottom;
290 } 287 }
291 } 288 }
292 DLLEXPORT void STDCALL FPDFLink_CloseWebLinks(FPDF_PAGELINK link_page) { 289 DLLEXPORT void STDCALL FPDFLink_CloseWebLinks(FPDF_PAGELINK link_page) {
293 delete (IPDF_LinkExtract*)link_page; 290 delete (IPDF_LinkExtract*)link_page;
294 } 291 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/fpdf_dataavail.cpp ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698