Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed)

Created:
5 years, 4 months ago by pfeldman
Modified:
5 years, 4 months ago
Reviewers:
dgozman, samli
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, aboxhall, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, nektarios, je_julie, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, dmazzoni, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: only set title w/ shortcut via Tooltip manager API. R=dgozman NOTRY= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200924

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -30 lines) Patch
M Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/NetworkConditionsSelector.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components_lazy/FilmStripView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/Spectrum.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesPopoverHelper.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/emulation/DevicesSettingsTab.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesUI.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/ColorSwatch.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/FilterBar.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/SettingsUI.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/SplitWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Toolbar.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Tooltip.js View 1 2 1 chunk +24 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/treeoutline.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
pfeldman
5 years, 4 months ago (2015-08-18 21:30:58 UTC) #1
dgozman
lgtm
5 years, 4 months ago (2015-08-19 01:41:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300703004/20001
5 years, 4 months ago (2015-08-19 18:45:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/58636) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-19 18:47:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300703004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300703004/40001
5 years, 4 months ago (2015-08-19 21:50:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95641)
5 years, 4 months ago (2015-08-19 22:44:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300703004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300703004/40001
5 years, 4 months ago (2015-08-20 18:30:09 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 19:42:07 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200924

Powered by Google App Engine
This is Rietveld 408576698