Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebaselined Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/elements/StylesPopoverHelper.js ('k') | Source/devtools/front_end/emulation/DevicesSettingsTab.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/Source/devtools/front_end/elements/StylesSidebarPane.js b/Source/devtools/front_end/elements/StylesSidebarPane.js

index 6ba5681be5c60907561eefc1d2e4149ee8cb997b..5ae4bd98491ce6513e74ae5905a451c32af37e6a 100644

--- a/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -92,7 +92,7 @@ WebInspector.StylesSidebarPane.createExclamationMark = function(property)

exclamationElement.className = "exclamation-mark";

if (!WebInspector.StylesSidebarPane.ignoreErrorsForProperty(property))

exclamationElement.type = "warning-icon";

- WebInspector.Tooltip.install(exclamationElement, WebInspector.CSSMetadata.cssPropertiesMetainfo.keySet()[property.name.toLowerCase()] ? WebInspector.UIString("Invalid property value") : WebInspector.UIString("Unknown property name"));

+ exclamationElement.title = WebInspector.CSSMetadata.cssPropertiesMetainfo.keySet()[property.name.toLowerCase()] ? WebInspector.UIString("Invalid property value") : WebInspector.UIString("Unknown property name");

return exclamationElement;

}

@@ -996,7 +996,7 @@ WebInspector.StylePropertiesSection = function(parentPane, styleRule)

if (this.editable && rule) {

var newRuleButton = closeBrace.createChild("div", "sidebar-pane-button-new-rule");

- WebInspector.Tooltip.install(newRuleButton, WebInspector.UIString("Insert Style Rule"));

+ newRuleButton.title = WebInspector.UIString("Insert Style Rule");

newRuleButton.addEventListener("click", this._onNewRuleClick.bind(this), false);

}