Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: Source/devtools/front_end/emulation/ResponsiveDesignView.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/emulation/OverridesView.js ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/emulation/ResponsiveDesignView.js
diff --git a/Source/devtools/front_end/emulation/ResponsiveDesignView.js b/Source/devtools/front_end/emulation/ResponsiveDesignView.js
index e9c1c8102daba370ca128e62f624b60898ee97c7..f6fdd51018f9fac647ac00c9bad40e2223695947 100644
--- a/Source/devtools/front_end/emulation/ResponsiveDesignView.js
+++ b/Source/devtools/front_end/emulation/ResponsiveDesignView.js
@@ -95,7 +95,7 @@ WebInspector.ResponsiveDesignView.prototype = {
this._decreasePageScaleButton.addEventListener("click", this._pageScaleButtonClicked.bind(this, false), false);
this._pageScaleLabel = this._pageScaleContainer.createChild("label", "responsive-design-page-scale-label");
- WebInspector.Tooltip.install(this._pageScaleLabel, WebInspector.UIString("Shift + drag to change page scale"));
+ this._pageScaleLabel.title = WebInspector.UIString("Shift + drag to change page scale");
this._pageScaleLabel.addEventListener("dblclick", this._resetPageScale.bind(this), false);
this._increasePageScaleButton = this._pageScaleContainer.createChild("button", "responsive-design-page-scale-button responsive-design-page-scale-increase");
@@ -539,9 +539,9 @@ WebInspector.ResponsiveDesignView.prototype = {
if (viewportChanged) {
this._pageScaleLabel.textContent = WebInspector.UIString("%.1f", this._viewport.pageScaleFactor);
- WebInspector.Tooltip.install(this._decreasePageScaleButton, WebInspector.UIString("Scale down (minimum %.1f)", this._viewport.minimumPageScaleFactor));
+ this._decreasePageScaleButton.title = WebInspector.UIString("Scale down (minimum %.1f)", this._viewport.minimumPageScaleFactor);
this._decreasePageScaleButton.disabled = this._viewport.pageScaleFactor <= this._viewport.minimumPageScaleFactor;
- WebInspector.Tooltip.install(this._increasePageScaleButton, WebInspector.UIString("Scale up (maximum %.1f)", this._viewport.maximumPageScaleFactor));
+ this._increasePageScaleButton.title = WebInspector.UIString("Scale up (maximum %.1f)", this._viewport.maximumPageScaleFactor);
this._increasePageScaleButton.disabled = this._viewport.pageScaleFactor >= this._viewport.maximumPageScaleFactor;
}
@@ -607,7 +607,7 @@ WebInspector.ResponsiveDesignView.prototype = {
var moreButtonContainer = this._toolbarElement.createChild("div", "responsive-design-more-button-container");
var moreButton = moreButtonContainer.createChild("button", "responsive-design-more-button");
- WebInspector.Tooltip.install(moreButton, WebInspector.UIString("More overrides"));
+ moreButton.title = WebInspector.UIString("More overrides");
moreButton.addEventListener("click", this._showEmulationInDrawer.bind(this), false);
moreButton.textContent = "\u2026";
},
@@ -672,7 +672,7 @@ WebInspector.ResponsiveDesignView.prototype = {
var resolutionFieldset2 = WebInspector.SettingsUI.createSettingFieldset(WebInspector.overridesSupport.settings.emulateResolution);
dprElement.appendChild(resolutionFieldset2);
var dprButton = resolutionFieldset2.createChild("div", "responsive-design-icon responsive-design-icon-dpr");
- WebInspector.Tooltip.install(dprButton, WebInspector.UIString("Device pixel ratio"));
+ dprButton.title = WebInspector.UIString("Device pixel ratio");
resolutionFieldset2.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 4, "1.9em", WebInspector.OverridesSupport.deviceScaleFactorValidator, true, true, WebInspector.UIString("\u2013")));
// Fit to window.
« no previous file with comments | « Source/devtools/front_end/emulation/OverridesView.js ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698