Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: Source/devtools/front_end/ui/FilterBar.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ui/ColorSwatch.js ('k') | Source/devtools/front_end/ui/SettingsUI.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/FilterBar.js
diff --git a/Source/devtools/front_end/ui/FilterBar.js b/Source/devtools/front_end/ui/FilterBar.js
index a9a3fba4e0ef753cbaa0c8bfec851d0cc35a1f18..333c93df852d2afde09213fa96db97d9950dcb8c 100644
--- a/Source/devtools/front_end/ui/FilterBar.js
+++ b/Source/devtools/front_end/ui/FilterBar.js
@@ -455,7 +455,7 @@ WebInspector.TextFilterUI.SuggestionBuilder.prototype = {
WebInspector.NamedBitSetFilterUI = function(items, setting)
{
this._filtersElement = createElementWithClass("div", "filter-bitset-filter");
- WebInspector.Tooltip.install(this._filtersElement, WebInspector.UIString("%sClick to select multiple types", WebInspector.KeyboardShortcut.shortcutToString("", WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta)));
+ this._filtersElement.title = WebInspector.UIString("%sClick to select multiple types", WebInspector.KeyboardShortcut.shortcutToString("", WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta));
this._allowedTypes = {};
this._typeFilterElements = {};
@@ -540,7 +540,7 @@ WebInspector.NamedBitSetFilterUI.prototype = {
typeFilterElement.typeName = name;
typeFilterElement.createTextChild(label);
if (title)
- WebInspector.Tooltip.install(typeFilterElement, title);
+ typeFilterElement.title = title;
typeFilterElement.addEventListener("click", this._onTypeFilterClicked.bind(this), false);
this._typeFilterElements[name] = typeFilterElement;
},
« no previous file with comments | « Source/devtools/front_end/ui/ColorSwatch.js ('k') | Source/devtools/front_end/ui/SettingsUI.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698