Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate()

Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate()

This patch introduces |isVisuallyEquivalentCandidate()| as replacement of
|PositionAlgorithm::isCandidate()| to make what this functions for
improving readability.

Following patch will move |isVisuallyEquivalentCandidate()| to
"VisibleUnits.cpp" to reduce usages of |InlineBox| from "Position.cpp" as
part of making |PositionAlgorithm| class to free from |InlineBox|.

BUG=518738
TEST=n/a; no behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200917

[yosin_UTC9, 2015-08-20 05:30:10]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2015-08-20 05:30:10]

PTAL

[tkent, 2015-08-20 05:42:41]

The code change lgtm.
But please explain in the CL description why you change it to a global function
insted of renaming it to PositionAlgorithm::isVisuallyEquivalentCandidate().

[yosin_UTC9, 2015-08-20 05:46:56]

On 2015/08/20 05:42:41, tkent wrote:
> The code change lgtm.
> But please explain in the CL description why you change it to a global
function
> instead of renaming it to PositionAlgorithm::isVisuallyEquivalentCandidate().

Thanks for reviewing.
I updated a description to explain why we would like to use global function.

[yosin_UTC9, 2015-08-20 08:26:09]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-20 08:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300303002/1

[commit-bot: I haz the power, 2015-08-20 08:28:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 08:28:55]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[yosin_UTC9, 2015-08-20 08:51:31]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-20 08:51:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1300303002/#ps20001
(title: "2015-08-20T17:50:23 Rebase")

[commit-bot: I haz the power, 2015-08-20 08:51:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300303002/20001

[commit-bot: I haz the power, 2015-08-20 12:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 12:00:12]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[yosin_UTC9, 2015-08-20 12:57:00]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-20 12:57:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300303002/20001

[commit-bot: I haz the power, 2015-08-20 13:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 13:01:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2015-08-20 13:44:29]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-20 13:44:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1300303002/#ps40001
(title: "2015-08-20T22:43:42 Rebase")

[commit-bot: I haz the power, 2015-08-20 13:44:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300303002/40001

[commit-bot: I haz the power, 2015-08-20 15:38:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 15:38:52]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2015-08-20 16:06:48]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-20 16:07:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300303002/40001

[commit-bot: I haz the power, 2015-08-20 16:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 16:12:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2015-08-20 16:28:07]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-20 16:28:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1300303002/#ps60001
(title: "2015-08-21T01:27:16 Rebase")

[commit-bot: I haz the power, 2015-08-20 16:28:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300303002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300303002/60001

[commit-bot: I haz the power, 2015-08-20 18:29:46]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200917