Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: Source/core/editing/Position.h

Issue 1300303002: Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-21T01:27:16 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/Position.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.h
diff --git a/Source/core/editing/Position.h b/Source/core/editing/Position.h
index e52eb086ebaa5d9314fb896aa48e4e0e7364fa8d..6aa73a495a5194e87d2d23ca466b116a28cf3a96 100644
--- a/Source/core/editing/Position.h
+++ b/Source/core/editing/Position.h
@@ -187,8 +187,6 @@ public:
PositionAlgorithm<Strategy> upstream(EditingBoundaryCrossingRule = CannotCrossEditingBoundary) const;
PositionAlgorithm<Strategy> downstream(EditingBoundaryCrossingRule = CannotCrossEditingBoundary) const;
- bool isCandidate() const;
-
static PositionAlgorithm<Strategy> beforeNode(Node* anchorNode);
static PositionAlgorithm<Strategy> afterNode(Node* anchorNode);
static PositionAlgorithm<Strategy> inParentBeforeNode(const Node& anchorNode);
@@ -444,6 +442,11 @@ CORE_EXPORT bool inRenderedText(const PositionInComposedTree&);
CORE_EXPORT int uncheckedPreviousOffset(const Node*, int current);
CORE_EXPORT int uncheckedNextOffset(const Node*, int current);
+// TODO(yosin) We should move |isVisuallyEquivalentCandidate()| to
+// "VisibleUnits.cpp" to reduce |LayoutObject| dependency in "Position.cpp".
+CORE_EXPORT bool isVisuallyEquivalentCandidate(const Position&);
+CORE_EXPORT bool isVisuallyEquivalentCandidate(const PositionInComposedTree&);
+
} // namespace blink
#ifndef NDEBUG
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698