Source/core/editing/FrameSelection.cpp - Issue 1300303002: Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1300303002: Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-21T01:27:16 Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index c1b5bbc6bf21cd758889ffdab88cdcd19e093712..c79e1053420a19809bb27fab965794a36b50d79b 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -1282,7 +1282,7 @@ IntRect FrameSelection::absoluteCaretBounds()

clearCaretRect();

} else {

if (isTextFormControl(m_selection))

- updateCaretRect(PositionWithAffinity(m_selection.start().isCandidate() ? m_selection.start() : Position(), m_selection.affinity()));

+ updateCaretRect(PositionWithAffinity(isVisuallyEquivalentCandidate(m_selection.start()) ? m_selection.start() : Position(), m_selection.affinity()));

else

updateCaretRect(VisiblePosition(m_selection.start(), m_selection.affinity()));

}

« no previous file with comments | « Source/core/editing/EditingUtilities.cpp ('k') | Source/core/editing/Position.h » ('j') | no next file with comments »