Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate()

Source/core/editing/EditingUtilities.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 320 matching lines @@
 }
 
 template <typename Strategy>
 PositionAlgorithm<Strategy> nextCandidateAlgorithm(const PositionAlgorithm<Strategy>& position)
 {
     PositionIteratorAlgorithm<Strategy> p(position);
 
     p.increment();
     while (!p.atEnd()) {
         PositionAlgorithm<Strategy> candidate = p.computePosition();
-        if (candidate.isCandidate())
+        if (isVisuallyEquivalentCandidate(candidate))
             return candidate;
 
         p.increment();
     }
 
     return PositionAlgorithm<Strategy>();
 }
 
 Position nextCandidate(const Position& position)
 {
@@ skipping 12 matching lines @@
 {
     if (position.isNull())
         return Position();
 
     PositionIterator p(position);
     Position downstreamStart = position.downstream();
 
     p.increment();
     while (!p.atEnd()) {
         Position candidate = p.computePosition();
-        if (candidate.isCandidate() && candidate.downstream() != downstreamStart)
+        if (isVisuallyEquivalentCandidate(candidate) && candidate.downstream() != downstreamStart)
             return candidate;
 
         p.increment();
     }
 
     return Position();
 }
 
 template <typename Strategy>
 PositionAlgorithm<Strategy> previousCandidateAlgorithm(const PositionAlgorithm<Strategy>& position)
 {
     PositionIteratorAlgorithm<Strategy> p(position);
 
     p.decrement();
     while (!p.atStart()) {
         PositionAlgorithm<Strategy> candidate = p.computePosition();
-        if (candidate.isCandidate())
+        if (isVisuallyEquivalentCandidate(candidate))
             return candidate;
 
         p.decrement();
     }
 
     return PositionAlgorithm<Strategy>();
 }
 
 Position previousCandidate(const Position& position)
 {
@@ skipping 13 matching lines @@
 {
     if (position.isNull())
         return PositionAlgorithm<Strategy>();
 
     PositionIteratorAlgorithm<Strategy> p(position);
     PositionAlgorithm<Strategy> downstreamStart = position.downstream();
 
     p.decrement();
     while (!p.atStart()) {
         PositionAlgorithm<Strategy> candidate = p.computePosition();
-        if (candidate.isCandidate() && candidate.downstream() != downstreamStart)
+        if (isVisuallyEquivalentCandidate(candidate) && candidate.downstream() != downstreamStart)
             return candidate;
 
         p.decrement();
     }
 
     return PositionAlgorithm<Strategy>();
 }
 
 Position previousVisuallyDistinctCandidate(const Position& position)
 {
@@ skipping 708 matching lines @@
 
 // return first preceding DOM position rendered at a different location, or "this"
 static Position previousCharacterPosition(const Position& position, TextAffinity affinity)
 {
     if (position.isNull())
         return Position();
 
     Element* fromRootEditableElement = position.anchorNode()->rootEditableElement();
 
     bool atStartOfLine = isStartOfLine(VisiblePosition(position, affinity));
-    bool rendered = position.isCandidate();
+    bool rendered = isVisuallyEquivalentCandidate(position);
 
     Position currentPos = position;
     while (!currentPos.atStartOfTree()) {
         currentPos = currentPos.previous();
 
         if (currentPos.anchorNode()->rootEditableElement() != fromRootEditableElement)
             return position;
 
         if (atStartOfLine || !rendered) {
-            if (currentPos.isCandidate())
+            if (isVisuallyEquivalentCandidate(currentPos))
                 return currentPos;
         } else if (rendersInDifferentPosition(position, currentPos)) {
             return currentPos;
         }
     }
 
     return position;
 }
 
 // This assumes that it starts in editable content.
@@ skipping 270 matching lines @@
     // if the selection starts just before a paragraph break, skip over it
     if (isEndOfParagraph(visiblePosition))
         return visiblePosition.next().deepEquivalent().downstream();
 
     // otherwise, make sure to be at the start of the first selected node,
     // instead of possibly at the end of the last node before the selection
     return visiblePosition.deepEquivalent().downstream();
 }
 
 } // namespace blink