Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299763002: DevTools: rely upon shouldHideOnDetach when considering re-layout of elements and sources panels. (Closed)

Created:
5 years, 4 months ago by pfeldman
Modified:
5 years, 4 months ago
Reviewers:
caseq
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: rely upon shouldHideOnDetach when considering re-layout of elements and sources panels. BUG=521202 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200732

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M Source/devtools/front_end/elements/ElementsPanel.js View 2 chunks +3 lines, -5 lines 1 comment Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionView.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/Widget.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pfeldman
5 years, 4 months ago (2015-08-17 21:58:34 UTC) #2
caseq
lgtm Can we add some diagnostic message when we can't switch mode on the fly? ...
5 years, 4 months ago (2015-08-17 22:02:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299763002/1
5 years, 4 months ago (2015-08-17 22:53:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99360)
5 years, 4 months ago (2015-08-18 00:08:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299763002/1
5 years, 4 months ago (2015-08-18 17:10:14 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:14:20 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200732

Powered by Google App Engine
This is Rietveld 408576698