Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: Source/devtools/front_end/elements/ElementsPanel.js

Issue 1299763002: DevTools: rely upon shouldHideOnDetach when considering re-layout of elements and sources panels. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/extensions/ExtensionPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/Source/devtools/front_end/elements/ElementsPanel.js b/Source/devtools/front_end/elements/ElementsPanel.js
index 112fd5f91c1f00f7164ef58ca3c94c4371c9b3cc..d984f25b43fd8b8691c58b53baf75a9be1305db4 100644
--- a/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/Source/devtools/front_end/elements/ElementsPanel.js
@@ -944,10 +944,10 @@ WebInspector.ElementsPanel.prototype = {
if (this.sidebarPaneView && vertically === !this._splitWidget.isVertical())
return;
- var extensionSidebarPanes = WebInspector.extensionServer.sidebarPanes();
- if (this.sidebarPaneView && extensionSidebarPanes.length)
+ if (this.sidebarPaneView && this.sidebarPaneView.shouldHideOnDetach())
return; // We can't reparent extension iframes.
+ var extensionSidebarPanes = WebInspector.extensionServer.sidebarPanes();
caseq 2015/08/17 22:02:42 nuke this?
if (this.sidebarPaneView) {
this.sidebarPaneView.detach();
this._splitWidget.uninstallResizer(this.sidebarPaneView.headerElement());
@@ -1061,10 +1061,8 @@ WebInspector.ElementsPanel.prototype = {
*/
_addExtensionSidebarPane: function(pane)
{
- if (pane.panelName() === this.name) {
- this.setHideOnDetach();
+ if (pane.panelName() === this.name)
this._extensionSidebarPanesContainer.addPane(pane);
- }
},
/**
« no previous file with comments | « no previous file | Source/devtools/front_end/extensions/ExtensionPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698