Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 1299763002: DevTools: rely upon shouldHideOnDetach when considering re-layout of elements and sources panels. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/Source/devtools/front_end/sources/SourcesPanel.js b/Source/devtools/front_end/sources/SourcesPanel.js
index 0d8f4a64b4e741ecb7620e6dae71aa4a75160279..882cd682771c301bb7f7c3481149b58b930fce71 100644
--- a/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/Source/devtools/front_end/sources/SourcesPanel.js
@@ -1142,6 +1142,9 @@ WebInspector.SourcesPanel.prototype = {
if (this.sidebarPaneView && vertically === !this._splitWidget.isVertical())
return;
+ if (this.sidebarPaneView && this.sidebarPaneView.shouldHideOnDetach())
+ return; // We can't reparent extension iframes.
+
if (this.sidebarPaneView)
this.sidebarPaneView.detach();
@@ -1230,10 +1233,8 @@ WebInspector.SourcesPanel.prototype = {
*/
_addExtensionSidebarPane: function(pane)
{
- if (pane.panelName() === this.name) {
- this.setHideOnDetach();
+ if (pane.panelName() === this.name)
this._extensionSidebarPanesContainer.addPane(pane);
- }
},
/**

Powered by Google App Engine
This is Rietveld 408576698