Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: Source/devtools/front_end/ui/Widget.js

Issue 1299763002: DevTools: rely upon shouldHideOnDetach when considering re-layout of elements and sources panels. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ui/Widget.js
diff --git a/Source/devtools/front_end/ui/Widget.js b/Source/devtools/front_end/ui/Widget.js
index 87100a7eeebb67a55c9f27c55b4e09866ef0a294..8ca45405faf8aad6bf7d3ff02813f8a1c91caa9a 100644
--- a/Source/devtools/front_end/ui/Widget.js
+++ b/Source/devtools/front_end/ui/Widget.js
@@ -106,12 +106,12 @@ WebInspector.Widget.prototype = {
/**
* @return {boolean}
*/
- _shouldHideOnDetach: function()
+ shouldHideOnDetach: function()
{
if (this._hideOnDetach)
return true;
for (var child of this._children) {
- if (child._shouldHideOnDetach())
+ if (child.shouldHideOnDetach())
return true;
}
return false;
@@ -283,7 +283,7 @@ WebInspector.Widget.prototype = {
if (this._parentIsShowing())
this._processWillHide();
- if (!overrideHideOnDetach && this._shouldHideOnDetach()) {
+ if (!overrideHideOnDetach && this.shouldHideOnDetach()) {
this.element.classList.add("hidden");
this._visible = false;
if (this._parentIsShowing())

Powered by Google App Engine
This is Rietveld 408576698