gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc - Issue 1299683002: gpu: If not cube complete, the texture isn't renderable, no matter mipmap complete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

Issue 1299683002: gpu: If not cube complete, the texture isn't renderable, no matter mipmap complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/mailbox_manager_sync.cc » ('j') | gpu/command_buffer/service/texture_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

index 8a55212ea0908c69f5351fb2d0b670fc93295b57..18a95fe15574365e51b83cbf434bfb0400a0c37a 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

@@ -2926,7 +2926,7 @@ TEST_P(GLES2DecoderManualInitTest, DrawWithGLImageExternal) {

SetupIndexBuffer();

AddExpectationsForSimulatedAttrib0(kMaxValidIndex + 1, 0);

SetupExpectationsForApplyingDefaultDirtyState();

- EXPECT_TRUE(group().texture_manager()->CanRender(texture_ref));

+ EXPECT_TRUE(group().texture_manager()->IsTextureComplete(texture_ref));

InSequence s;

EXPECT_CALL(*gl_, GetError())