gpu/command_buffer/service/mailbox_manager_sync.cc - Issue 1299683002: gpu: If not cube complete, the texture isn't renderable, no matter mipmap complete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/mailbox_manager_sync.cc

Issue 1299683002: gpu: If not cube complete, the texture isn't renderable, no matter mipmap complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc ('k') | gpu/command_buffer/service/texture_manager.h » ('j') | gpu/command_buffer/service/texture_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/mailbox_manager_sync.cc

diff --git a/gpu/command_buffer/service/mailbox_manager_sync.cc b/gpu/command_buffer/service/mailbox_manager_sync.cc

index be12b3a8fe86cbe3408c57cbfb65ca6411ddaec2..1f1c149a7ef457f444e69c3cadedb1c73f42e206 100644

--- a/gpu/command_buffer/service/mailbox_manager_sync.cc

+++ b/gpu/command_buffer/service/mailbox_manager_sync.cc

@@ -176,7 +176,7 @@ bool MailboxManagerSync::SkipTextureWorkarounds(const Texture* texture) {

// Cannot support mips due to support mismatch between

// EGL_KHR_gl_texture_2D_image and glEGLImageTargetTexture2DOES for

// texture levels.

- bool has_mips = texture->NeedsMips() && texture->texture_complete();

+ bool has_mips = texture->NeedsMips() && texture->texture_2d_complete();

return texture->target() != GL_TEXTURE_2D || has_mips;

}