Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

Issue 1299683002: gpu: If not cube complete, the texture isn't renderable, no matter mipmap complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "gpu/command_buffer/common/gles2_cmd_format.h" 9 #include "gpu/command_buffer/common/gles2_cmd_format.h"
10 #include "gpu/command_buffer/common/gles2_cmd_utils.h" 10 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
(...skipping 2908 matching lines...) Expand 10 before | Expand all | Expand 10 after
2919 group().texture_manager()->SetLevelImage( 2919 group().texture_manager()->SetLevelImage(
2920 texture_ref, GL_TEXTURE_EXTERNAL_OES, 0, image.get()); 2920 texture_ref, GL_TEXTURE_EXTERNAL_OES, 0, image.get());
2921 2921
2922 DoBindTexture(GL_TEXTURE_EXTERNAL_OES, client_texture_id_, kServiceTextureId); 2922 DoBindTexture(GL_TEXTURE_EXTERNAL_OES, client_texture_id_, kServiceTextureId);
2923 EXPECT_EQ(GL_NO_ERROR, GetGLError()); 2923 EXPECT_EQ(GL_NO_ERROR, GetGLError());
2924 2924
2925 SetupSamplerExternalProgram(); 2925 SetupSamplerExternalProgram();
2926 SetupIndexBuffer(); 2926 SetupIndexBuffer();
2927 AddExpectationsForSimulatedAttrib0(kMaxValidIndex + 1, 0); 2927 AddExpectationsForSimulatedAttrib0(kMaxValidIndex + 1, 0);
2928 SetupExpectationsForApplyingDefaultDirtyState(); 2928 SetupExpectationsForApplyingDefaultDirtyState();
2929 EXPECT_TRUE(group().texture_manager()->CanRender(texture_ref)); 2929 EXPECT_TRUE(group().texture_manager()->IsTextureComplete(texture_ref));
2930 2930
2931 InSequence s; 2931 InSequence s;
2932 EXPECT_CALL(*gl_, GetError()) 2932 EXPECT_CALL(*gl_, GetError())
2933 .WillOnce(Return(GL_NO_ERROR)) 2933 .WillOnce(Return(GL_NO_ERROR))
2934 .RetiresOnSaturation(); 2934 .RetiresOnSaturation();
2935 EXPECT_CALL(*gl_, ActiveTexture(GL_TEXTURE0)).Times(1).RetiresOnSaturation(); 2935 EXPECT_CALL(*gl_, ActiveTexture(GL_TEXTURE0)).Times(1).RetiresOnSaturation();
2936 EXPECT_CALL(*image.get(), WillUseTexImage()).Times(1).RetiresOnSaturation(); 2936 EXPECT_CALL(*image.get(), WillUseTexImage()).Times(1).RetiresOnSaturation();
2937 EXPECT_CALL(*gl_, GetError()) 2937 EXPECT_CALL(*gl_, GetError())
2938 .WillOnce(Return(GL_NO_ERROR)) 2938 .WillOnce(Return(GL_NO_ERROR))
2939 .RetiresOnSaturation(); 2939 .RetiresOnSaturation();
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
3281 // TODO(gman): CompressedTexSubImage2DImmediate 3281 // TODO(gman): CompressedTexSubImage2DImmediate
3282 3282
3283 // TODO(gman): TexImage2D 3283 // TODO(gman): TexImage2D
3284 3284
3285 // TODO(gman): TexImage2DImmediate 3285 // TODO(gman): TexImage2DImmediate
3286 3286
3287 // TODO(gman): TexSubImage2DImmediate 3287 // TODO(gman): TexSubImage2DImmediate
3288 3288
3289 } // namespace gles2 3289 } // namespace gles2
3290 } // namespace gpu 3290 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698