Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1299583002: Revert of Print stack traces in child processes when browser tests failed. (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Print stack traces in child processes when browser tests failed. (patchset #5 id:80001 of https://codereview.chromium.org/1291553003/ ) Reason for revert: This is unfortunately breaking Windows 10 in a major way. I did a local bisect and narrowed it down to this CL. BUG=521242 Original issue's description: > Print stack traces in child processes when browser tests failed. > > The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds. > > BUG=517488, 358267 > > Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975 > Cr-Commit-Position: refs/heads/master@{#343240} TBR=scottmg@chromium.org,jln@chromium.org,wfh@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517488, 358267 Committed: https://crrev.com/531d19bbe954ecd92d2027d2c4d0d6c850cfe0de Cr-Commit-Position: refs/heads/master@{#343603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -111 lines) Patch
M base/debug/stack_trace.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/stack_trace_posix.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M base/debug/stack_trace_win.cc View 7 chunks +66 lines, -69 lines 0 comments Download
M base/process/launch_win.cc View 1 chunk +2 lines, -16 lines 0 comments Download
M components/nacl/loader/nacl_main_platform_delegate_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/common/sandbox_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +11 lines, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/utility/utility_main.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Print stack traces in child processes when browser tests failed.
5 years, 4 months ago (2015-08-16 17:36:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299583002/1
5 years, 4 months ago (2015-08-16 17:36:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-16 17:36:57 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-16 17:37:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/531d19bbe954ecd92d2027d2c4d0d6c850cfe0de
Cr-Commit-Position: refs/heads/master@{#343603}

Powered by Google App Engine
This is Rietveld 408576698