Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2900)

Unified Diff: content/renderer/renderer_main.cc

Issue 1299583002: Revert of Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/ppapi_plugin/ppapi_thread.cc ('k') | content/renderer/renderer_main_platform_delegate_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_main.cc
diff --git a/content/renderer/renderer_main.cc b/content/renderer/renderer_main.cc
index 3a34300d2d65ea4659564afebbc07711485a2679..2d82597ee48cf7142cfc54e85ed5c5cd6e8e08cb 100644
--- a/content/renderer/renderer_main.cc
+++ b/content/renderer/renderer_main.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "base/debug/debugger.h"
#include "base/debug/leak_annotations.h"
+#include "base/debug/stack_trace.h"
#include "base/i18n/rtl.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/field_trial.h"
@@ -183,8 +184,17 @@
renderer_scheduler.Pass());
#endif
bool run_loop = true;
- if (!no_sandbox)
+ if (!no_sandbox) {
run_loop = platform.EnableSandbox();
+ } else {
+ LOG(ERROR) << "Running without renderer sandbox";
+#if !defined(NDEBUG) || (defined(CFI_ENFORCEMENT) && !defined(OFFICIAL_BUILD))
+ // For convenience, we print the stack traces for crashes. When sandbox
+ // is enabled, the in-process stack dumping is enabled as part of the
+ // EnableSandbox() call.
+ base::debug::EnableInProcessStackDumping();
+#endif
+ }
#if defined(OS_POSIX) && !defined(OS_MACOSX)
RenderProcessImpl render_process;
RenderThreadImpl::Create(main_message_loop.Pass(),
« no previous file with comments | « content/ppapi_plugin/ppapi_thread.cc ('k') | content/renderer/renderer_main_platform_delegate_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698