content/app/content_main_runner.cc - Issue 1299583002: Revert of Print stack traces in child processes when browser tests failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/app/content_main_runner.cc

Issue 1299583002: Revert of Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/app/content_main_runner.cc

diff --git a/content/app/content_main_runner.cc b/content/app/content_main_runner.cc

index 55c6ac7f651137d6e9f55fb46e0de6c78a286754..df069e87e07a6c77125fe6af3f16f93918126926 100644

--- a/content/app/content_main_runner.cc

+++ b/content/app/content_main_runner.cc

@@ -10,7 +10,6 @@

#include "base/at_exit.h"

#include "base/command_line.h"

#include "base/debug/debugger.h"

-#include "base/debug/stack_trace.h"

#include "base/files/file_path.h"

#include "base/i18n/icu_util.h"

#include "base/lazy_instance.h"

@@ -196,15 +195,6 @@

// surface UI -- but it's likely they get this wrong too so why not.

setlocale(LC_NUMERIC, "C");

#endif

-#if !defined(OFFICIAL_BUILD)

- // Print stack traces to stderr when crashes occur. This opens up security

- // holes so it should never be enabled for official builds.

- base::debug::EnableInProcessStackDumping();

-#if defined(OS_WIN)

- LoadLibraryA("dbghelp.dll");

-#endif

}

class ContentClientInitializer {

« no previous file with comments | « components/nacl/loader/nacl_main_platform_delegate_win.cc ('k') | content/common/sandbox_win.cc » ('j') | no next file with comments »