Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1298893003: Enable is and as checks on non-ground types (Closed)

Created:
5 years, 4 months ago by vsm
Modified:
5 years, 4 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable is and as checks on non-ground types Failures generate a StrongModeError. Fixes #236. Partially addresses #238. Some issues to do: - We're too eager to throw a StrongModeError. E.g., <int>[] is List<String> will throw. - We don't differentiate between implicit and explicit casts. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1aa9fe9760a501874360040012f9901fd66b11f6

Patch Set 1 #

Patch Set 2 : Minor fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -87 lines) Patch
M lib/runtime/_classes.js View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/_errors.js View 1 1 chunk +9 lines, -0 lines 0 comments Download
M lib/runtime/_operations.js View 2 chunks +31 lines, -12 lines 1 comment Download
M lib/runtime/dart_library.js View 3 chunks +5 lines, -3 lines 0 comments Download
M lib/runtime/dart_runtime.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/runtime/dart_utils.js View 2 chunks +16 lines, -4 lines 0 comments Download
M lib/src/checker/checker.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/info.dart View 1 1 chunk +7 lines, -3 lines 0 comments Download
M test/browser/runtime_tests.js View 1 17 chunks +73 lines, -44 lines 0 comments Download
M test/checker/checker_test.dart View 1 1 chunk +10 lines, -10 lines 0 comments Download
M tool/sdk_expected_errors.txt View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 4 months ago (2015-08-18 22:56:26 UTC) #2
Leaf
lgtm with comment. https://codereview.chromium.org/1298893003/diff/20001/lib/runtime/_operations.js File lib/runtime/_operations.js (right): https://codereview.chromium.org/1298893003/diff/20001/lib/runtime/_operations.js#newcode212 lib/runtime/_operations.js:212: dart_utils.throwStrongModeError('Strong mode cast failure from ' ...
5 years, 4 months ago (2015-08-18 23:31:12 UTC) #3
vsm
5 years, 4 months ago (2015-08-19 13:15:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1aa9fe9760a501874360040012f9901fd66b11f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698