test/checker/checker_test.dart - Issue 1298893003: Enable is and as checks on non-ground types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/checker/checker_test.dart

Issue 1298893003: Enable is and as checks on non-ground types (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Minor fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/checker/checker_test.dart

diff --git a/test/checker/checker_test.dart b/test/checker/checker_test.dart

index 2803beccfc21494319b25937e41869cd7bb738bf..1a1abc134469a127564520a8f059ec5168a9d5bb 100644

--- a/test/checker/checker_test.dart

+++ b/test/checker/checker_test.dart

@@ -2516,18 +2516,18 @@ void main() {

void main() {

bool b;

- b = /*severe:InvalidRuntimeCheckError*/foo is I2I;

- b = /*severe:InvalidRuntimeCheckError*/foo is D2I;

- b = /*severe:InvalidRuntimeCheckError*/foo is I2D;

+ b = /*info:NonGroundTypeCheckInfo*/foo is I2I;

+ b = /*info:NonGroundTypeCheckInfo*/foo is D2I;

+ b = /*info:NonGroundTypeCheckInfo*/foo is I2D;

b = foo is D2D;

- b = /*severe:InvalidRuntimeCheckError*/bar is II2I;

- b = /*severe:InvalidRuntimeCheckError*/bar is DI2I;

- b = /*severe:InvalidRuntimeCheckError*/bar is ID2I;

- b = /*severe:InvalidRuntimeCheckError*/bar is II2D;

- b = /*severe:InvalidRuntimeCheckError*/bar is DD2I;

- b = /*severe:InvalidRuntimeCheckError*/bar is DI2D;

- b = /*severe:InvalidRuntimeCheckError*/bar is ID2D;

+ b = /*info:NonGroundTypeCheckInfo*/bar is II2I;

+ b = /*info:NonGroundTypeCheckInfo*/bar is DI2I;

+ b = /*info:NonGroundTypeCheckInfo*/bar is ID2I;

+ b = /*info:NonGroundTypeCheckInfo*/bar is II2D;

+ b = /*info:NonGroundTypeCheckInfo*/bar is DD2I;

+ b = /*info:NonGroundTypeCheckInfo*/bar is DI2D;

+ b = /*info:NonGroundTypeCheckInfo*/bar is ID2D;

b = bar is DD2D;

// For as, the validity of checks is deferred to runtime.