Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tool/sdk_expected_errors.txt

Issue 1298893003: Enable is and as checks on non-ground types (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Minor fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/runtime/_operations.js ('K') | « test/checker/checker_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index f85ef85ff19ac65409132397921fbdd2057aa6a8..24c5cef4ee59abcba3f0bf8c418a8ba1d6202eb2 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -108,7 +108,6 @@ warning: [DownCastComposite] pattern.allMatches(receiver) (dynamic) will need ru
warning: [DownCastComposite] JS('var', '#.splice(#, 2)[1]', bucket, index) (dynamic) will need runtime check to cast to type V (dart:collection, line 179, col 12)
warning: [DownCastComposite] key (dynamic) will need runtime check to cast to type K (dart:collection, line 193, col 14)
warning: [DownCastComposite] _getTableEntry(table, key) (dynamic) will need runtime check to cast to type V (dart:collection, line 261, col 17)
-severe: [InvalidRuntimeCheckError] Invalid runtime check on non-ground type K (dart:collection, line 372, col 61)
warning: [DownCastComposite] key (dynamic) will need runtime check to cast to type K (dart:collection, line 397, col 49)
warning: [DownCastComposite] JS('var', '#[#]', bucket, i) (dynamic) will need runtime check to cast to type K (dart:collection, line 404, col 19)
warning: [DownCastComposite] key (dynamic) will need runtime check to cast to type K (dart:collection, line 404, col 49)
@@ -119,7 +118,6 @@ warning: [DownCastComposite] cell._value (dynamic) will need runtime check to ca
warning: [DownCastComposite] cell._key (dynamic) will need runtime check to cast to type K (dart:collection, line 642, col 14)
warning: [DownCastComposite] cell._value (dynamic) will need runtime check to cast to type V (dart:collection, line 642, col 25)
warning: [DownCastComposite] cell._value (dynamic) will need runtime check to cast to type V (dart:collection, line 665, col 12)
-severe: [InvalidRuntimeCheckError] Invalid runtime check on non-ground type K (dart:collection, line 795, col 61)
warning: [DownCastComposite] key (dynamic) will need runtime check to cast to type K (dart:collection, line 820, col 49)
warning: [DownCastComposite] cell._key (dynamic) will need runtime check to cast to type K (dart:collection, line 828, col 19)
warning: [DownCastComposite] key (dynamic) will need runtime check to cast to type K (dart:collection, line 828, col 30)
@@ -127,7 +125,6 @@ warning: [DownCastComposite] cell._key (dynamic) will need runtime check to cast
warning: [DownCastComposite] _cell._key (dynamic) will need runtime check to cast to type E (dart:collection, line 889, col 18)
warning: [DownCastComposite] this.contains(object) ? object : null (Object) will need runtime check to cast to type E (dart:collection, line 951, col 14)
warning: [DownCastComposite] bucket[index] (dynamic) will need runtime check to cast to type E (dart:collection, line 962, col 12)
-severe: [InvalidRuntimeCheckError] Invalid runtime check on non-ground type E (dart:collection, line 1194, col 61)
warning: [DownCastComposite] JS('var', '#[#]', bucket, i) (dynamic) will need runtime check to cast to type E (dart:collection, line 1202, col 21)
warning: [DownCastComposite] element (dynamic) will need runtime check to cast to type E (dart:collection, line 1202, col 51)
warning: [DownCastComposite] element (dynamic) will need runtime check to cast to type E (dart:collection, line 1212, col 47)
@@ -138,7 +135,6 @@ warning: [DownCastComposite] cell._element (dynamic) will need runtime check to
warning: [DownCastComposite] _first._element (dynamic) will need runtime check to cast to type E (dart:collection, line 1357, col 12)
warning: [DownCastComposite] _last._element (dynamic) will need runtime check to cast to type E (dart:collection, line 1362, col 12)
warning: [DownCastComposite] cell._element (dynamic) will need runtime check to cast to type E (dart:collection, line 1431, col 19)
-severe: [InvalidRuntimeCheckError] Invalid runtime check on non-ground type E (dart:collection, line 1596, col 61)
warning: [DownCastComposite] cell._element (dynamic) will need runtime check to cast to type E (dart:collection, line 1606, col 21)
warning: [DownCastComposite] element (dynamic) will need runtime check to cast to type E (dart:collection, line 1606, col 36)
warning: [DownCastComposite] element (dynamic) will need runtime check to cast to type E (dart:collection, line 1616, col 47)
@@ -179,7 +175,6 @@ severe: [AnalyzerMessage] The getter '_comparator' is not defined for the class
warning: [DownCastComposite] current (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 151, col 12)
warning: [DownCastComposite] current (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 167, col 12)
warning: [DownCastComposite] (compare == null) ? Comparable.compare : compare (Function) will need runtime check to cast to type (K, K) → int (dart:collection/splay_tree.dart, line 265, col 23)
-severe: [InvalidRuntimeCheckError] Invalid runtime check on non-ground type K (dart:collection/splay_tree.dart, line 266, col 65)
warning: [DownCastComposite] v (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 275, col 40)
warning: [DownCastComposite] k (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 275, col 35)
warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 328, col 25)
@@ -201,7 +196,6 @@ warning: [DownCastComposite] node.key (dynamic) will need runtime check to cast
warning: [DownCastComposite] node.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 633, col 42)
warning: [DownCastComposite] node (_SplayTreeNode<dynamic>) will need runtime check to cast to type _SplayTreeNode<K> (dart:collection/splay_tree.dart, line 641, col 55)
warning: [DownCastComposite] (compare == null) ? Comparable.compare : compare (Function) will need runtime check to cast to type (E, E) → int (dart:collection/splay_tree.dart, line 691, col 23)
-severe: [InvalidRuntimeCheckError] Invalid runtime check on non-ground type E (dart:collection/splay_tree.dart, line 692, col 65)
warning: [DownCastComposite] elements (Iterable<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/splay_tree.dart, line 705, col 29)
warning: [DownCastComposite] _first.key (dynamic) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 723, col 12)
warning: [DownCastComposite] _last.key (dynamic) will need runtime check to cast to type E (dart:collection/splay_tree.dart, line 728, col 12)
« lib/runtime/_operations.js ('K') | « test/checker/checker_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698