lib/src/checker/checker.dart - Issue 1298893003: Enable is and as checks on non-ground types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/checker/checker.dart

Issue 1298893003: Enable is and as checks on non-ground types (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Minor fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/checker/checker.dart

diff --git a/lib/src/checker/checker.dart b/lib/src/checker/checker.dart

index e0e4d11d41327a47ca11bd48271a63058aa2637e..1cabddd764ee02584ce2fa7c6aa0e6d121dead82 100644

--- a/lib/src/checker/checker.dart

+++ b/lib/src/checker/checker.dart

@@ -694,7 +694,7 @@ class CodeChecker extends RecursiveAstVisitor {

void _checkRuntimeTypeCheck(AstNode node, TypeName typeName) {

var type = getType(typeName);

if (!rules.isGroundType(type)) {

- _recordMessage(new InvalidRuntimeCheckError(node, type));

+ _recordMessage(new NonGroundTypeCheckInfo(node, type));

}