Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298763002: Move normal map creation methods to sk_tools (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move normal map creation methods to sk_tools Split off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call) Committed: https://skia.googlesource.com/skia/+/ea4529d09a6ad50582e348eee1c275a9ffb59278

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -73 lines) Patch
M gm/lightingshader.cpp View 1 8 chunks +34 lines, -73 lines 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.cpp View 2 chunks +108 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
robertphillips
5 years, 4 months ago (2015-08-17 21:27:06 UTC) #2
bsalomon
On 2015/08/17 21:27:06, robertphillips wrote: lgtm
5 years, 4 months ago (2015-08-17 21:41:02 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298763002/20001
5 years, 4 months ago (2015-08-17 21:47:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-17 21:56:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298763002/20001
5 years, 4 months ago (2015-08-17 22:04:19 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 22:04:50 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ea4529d09a6ad50582e348eee1c275a9ffb59278

Powered by Google App Engine
This is Rietveld 408576698