Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chromecast/browser/cast_content_browser_client.cc

Issue 1298473004: [Chromecast] Moves persistent UMA client ID handling to common code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: moves android dep to correct target Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_content_browser_client.cc
diff --git a/chromecast/browser/cast_content_browser_client.cc b/chromecast/browser/cast_content_browser_client.cc
index e445c1e1ab0a2e46c5ccc4bf583368b6b324234c..2b4a5dff1b5f8e04bf87d13e0ecc7495abc84297 100644
--- a/chromecast/browser/cast_content_browser_client.cc
+++ b/chromecast/browser/cast_content_browser_client.cc
@@ -87,11 +87,21 @@ CastContentBrowserClient::CreateMediaPipelineBackend(
}
#endif
+void CastContentBrowserClient::SetMetricsClientId(
+ const std::string& client_id) {
+}
+
+void CastContentBrowserClient::RegisterMetricsProviders(
+ ::metrics::MetricsService* metrics_service) {
+}
+
content::BrowserMainParts* CastContentBrowserClient::CreateBrowserMainParts(
const content::MainFunctionParams& parameters) {
- return new CastBrowserMainParts(parameters,
- url_request_context_factory_.get(),
- CreateAudioManagerFactory());
+ content::BrowserMainParts* parts = new CastBrowserMainParts(
+ parameters, url_request_context_factory_.get(),
+ CreateAudioManagerFactory());
+ CastBrowserProcess::GetInstance()->SetCastContentBrowserClient(this);
halliwell 2015/08/19 20:56:18 why not pass 'this' through CastBrowserMainParts c
gunsch 2015/08/19 21:23:12 Discussed offline, this is in keeping with CastBro
+ return parts;
}
void CastContentBrowserClient::RenderProcessWillLaunch(

Powered by Google App Engine
This is Rietveld 408576698