[Chromecast] Moves persistent UMA client ID handling to common code.

chromecast/browser/cast_content_browser_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_content_browser_client.h"
 
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
@@ skipping 69 matching lines @@
 
 #if !defined(OS_ANDROID)
 scoped_ptr<media::MediaPipelineBackend>
 CastContentBrowserClient::CreateMediaPipelineBackend(
     const media::MediaPipelineDeviceParams& params) {
   return make_scoped_ptr(
       media::CastMediaShlib::CreateMediaPipelineBackend(params));
 }
 #endif
 
+void CastContentBrowserClient::SetMetricsClientId(
+    const std::string& client_id) {
+}
+
+void CastContentBrowserClient::RegisterMetricsProviders(
+    ::metrics::MetricsService* metrics_service) {
+}
+
 content::BrowserMainParts* CastContentBrowserClient::CreateBrowserMainParts(
     const content::MainFunctionParams& parameters) {
-  return new CastBrowserMainParts(parameters,
-                                  url_request_context_factory_.get(),
-                                  CreateAudioManagerFactory());
+  content::BrowserMainParts* parts = new CastBrowserMainParts(
+      parameters, url_request_context_factory_.get(),
+      CreateAudioManagerFactory());
+  CastBrowserProcess::GetInstance()->SetCastContentBrowserClient(this);

[halliwell, 2015/08/19 20:56:18]

why not pass 'this' through CastBrowserMainParts ctor, which creates
CastBrowserProcess?  then no need for a setter.

[gunsch, 2015/08/19 21:23:12]

Discussed offline, this is in keeping with CastBrowserProcess's existing
pattern. Will leave as-is.

+  return parts;
 }
 
 void CastContentBrowserClient::RenderProcessWillLaunch(
     content::RenderProcessHost* host) {
 #if !defined(OS_ANDROID)
   scoped_refptr<media::CmaMessageFilterHost> cma_message_filter(
       new media::CmaMessageFilterHost(
           host->GetID(),
           base::Bind(&CastContentBrowserClient::CreateMediaPipelineBackend,
                      base::Unretained(this))));
@@ skipping 315 matching lines @@
         process_type, dumps_path, false /* upload */);
   // StartUploaderThread() even though upload is diferred.
   // Breakpad-related memory is freed in the uploader thread.
   crash_handler->StartUploaderThread();
   return crash_handler;
 }
 #endif  // !defined(OS_ANDROID)
 
 }  // namespace shell
 }  // namespace chromecast