chromecast/browser/metrics/cast_metrics_service_client.h - Issue 1298473004: [Chromecast] Moves persistent UMA client ID handling to common code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 1298473004: [Chromecast] Moves persistent UMA client ID handling to common code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: moves android dep to correct target Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/cast_content_browser_client.cc ('K') | « chromecast/browser/cast_content_browser_client.cc ('k') | chromecast/browser/metrics/cast_metrics_service_client.cc » ('j') | chromecast/browser/metrics/cast_metrics_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index 771b78edb02f0342c74472705700cd83755190b5..896759ee87932bdd53dc2606bd6148a7a7b5ffa6 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -48,6 +48,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

net::URLRequestContextGetter* request_context);

static void RegisterPrefs(PrefRegistrySimple* registry);

+ void SetPersistedClientId(const std::string& client_id);

byungchul 2015/08/19 21:11:20 SetPersistedClientId() is confusing with SetMetric

gunsch 2015/08/19 21:23:12 How about SetForceClientId? (added some docs to ex

void Initialize(CastService* cast_service);

void Finalize();

@@ -87,6 +88,8 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

PrefService* const pref_service_;

CastService* cast_service_;

std::string client_id_;

+ std::string persisted_client_id_;

+ bool client_info_loaded_;

#if defined(OS_LINUX)

ExternalMetrics* external_metrics_;