Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chromecast/browser/cast_content_browser_client.h

Issue 1298473004: [Chromecast] Moves persistent UMA client ID handling to common code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: moves android dep to correct target Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_content_browser_client.h
diff --git a/chromecast/browser/cast_content_browser_client.h b/chromecast/browser/cast_content_browser_client.h
index aca5d645119bd32d78b67aab8bd498fbfe0315c5..339f0c0069d1056cc6b407e6a9ae9d3520332290 100644
--- a/chromecast/browser/cast_content_browser_client.h
+++ b/chromecast/browser/cast_content_browser_client.h
@@ -25,8 +25,8 @@ namespace media {
class AudioManagerFactory;
}
-namespace net {
-class HostResolver;
+namespace metrics {
+class MetricsService;
}
namespace chromecast {
@@ -40,7 +40,7 @@ namespace shell {
class CastBrowserMainParts;
class URLRequestContextFactory;
-class CastContentBrowserClient: public content::ContentBrowserClient {
+class CastContentBrowserClient : public content::ContentBrowserClient {
public:
// Creates an implementation of CastContentBrowserClient. Platform should
// link in an implementation as needed.
@@ -66,6 +66,13 @@ class CastContentBrowserClient: public content::ContentBrowserClient {
const media::MediaPipelineDeviceParams& params);
#endif
+ // Invoked when the metrics client ID changes.
+ virtual void SetMetricsClientId(const std::string& client_id);
+
+ // Allows registration of extra metrics providers.
+ virtual void RegisterMetricsProviders(
+ ::metrics::MetricsService* metrics_service);
+
// content::ContentBrowserClient implementation:
content::BrowserMainParts* CreateBrowserMainParts(
const content::MainFunctionParams& parameters) override;

Powered by Google App Engine
This is Rietveld 408576698