Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 1297063002: MD downloads: update toolbar styles (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: update toolbar styles 1) Update height to 56px 2) Remove drop shadow 3) Change icon button sizes (e.g. search magnifying glass) 4) Change action button text size/color 5) Change "Downloads" header size BUG=520715 R=groby@chromium.org Committed: https://crrev.com/d2273a9b0e2178a86623a247ba2f14657ff35b4c Cr-Commit-Position: refs/heads/master@{#343989}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M chrome/browser/resources/md_downloads/manager.css View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.css View 4 chunks +15 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (2 generated)
Dan Beam
5 years, 4 months ago (2015-08-17 21:55:05 UTC) #1
groby-ooo-7-16
https://codereview.chromium.org/1297063002/diff/1/chrome/browser/resources/md_downloads/manager.css File chrome/browser/resources/md_downloads/manager.css (right): https://codereview.chromium.org/1297063002/diff/1/chrome/browser/resources/md_downloads/manager.css#newcode19 chrome/browser/resources/md_downloads/manager.css:19: /* TODO(dbeam): upgrade to 1.0.4 to use --paper-header-panel-shadow. dschuyler ...
5 years, 4 months ago (2015-08-17 23:54:10 UTC) #3
Dan Beam
https://codereview.chromium.org/1297063002/diff/1/chrome/browser/resources/md_downloads/manager.css File chrome/browser/resources/md_downloads/manager.css (right): https://codereview.chromium.org/1297063002/diff/1/chrome/browser/resources/md_downloads/manager.css#newcode19 chrome/browser/resources/md_downloads/manager.css:19: /* TODO(dbeam): upgrade to 1.0.4 to use --paper-header-panel-shadow. On ...
5 years, 4 months ago (2015-08-17 23:55:59 UTC) #4
groby-ooo-7-16
lgtm
5 years, 4 months ago (2015-08-18 18:25:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297063002/40001
5 years, 4 months ago (2015-08-18 18:26:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 4 months ago (2015-08-18 19:13:20 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 19:13:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2273a9b0e2178a86623a247ba2f14657ff35b4c
Cr-Commit-Position: refs/heads/master@{#343989}

Powered by Google App Engine
This is Rietveld 408576698