Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299803002: MD Downloads: update page margins/layout (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: update page margins/layout 1) Update background color 2) Make line rules full width 3) Change card margins 4) Change timestamp font size/color R=groby@chromium.org BUG=520722 Committed: https://crrev.com/b683c66f822e233a289da00a46632889eac6c5f1 Cr-Commit-Position: refs/heads/master@{#343907}

Patch Set 1 #

Total comments: 2

Patch Set 2 : adding deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -69 lines) Patch
M chrome/browser/resources/md_downloads/downloads.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.css View 1 4 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 1 chunk +54 lines, -56 lines 0 comments Download

Depends on Patchset:

Issue 1287053004 Patch 20001

Dependent Patchsets:

Issue 1297063002 Patch 40001

Messages

Total messages: 7 (2 generated)
Dan Beam
https://codereview.chromium.org/1299803002/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (left): https://codereview.chromium.org/1299803002/diff/1/chrome/browser/resources/md_downloads/item.html#oldcode19 chrome/browser/resources/md_downloads/item.html:19: <div id="content-wrapper"> diff: you're drunk; go home. (I just ...
5 years, 4 months ago (2015-08-17 23:54:13 UTC) #1
groby-ooo-7-16
Yay diff algorithms! :) LGTM https://codereview.chromium.org/1299803002/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (left): https://codereview.chromium.org/1299803002/diff/1/chrome/browser/resources/md_downloads/item.html#oldcode19 chrome/browser/resources/md_downloads/item.html:19: <div id="content-wrapper"> On 2015/08/17 ...
5 years, 4 months ago (2015-08-17 23:58:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299803002/20001
5 years, 4 months ago (2015-08-18 13:20:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 13:50:50 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 13:51:19 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b683c66f822e233a289da00a46632889eac6c5f1
Cr-Commit-Position: refs/heads/master@{#343907}

Powered by Google App Engine
This is Rietveld 408576698