Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1294253003: MD Downloads: update basic cards (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: update basic cards 1) Update local file links and URL colors/weights 2) Remove "Show in f{ol,in}der" button uppercasing 3) Make remove (X) slightly larger 4) Remove min-width on <paper-button> that was messing with alignments BUG=520723 R=michaelpg@chromium.org Committed: https://crrev.com/bebbc793a786a72b55856f38843548a6724b84cb Cr-Commit-Position: refs/heads/master@{#344020}

Patch Set 1 : tweaks #

Patch Set 2 : tweaks #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 1 4 chunks +19 lines, -11 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_downloads/shared_style.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css View 1 chunk +10 lines, -0 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (9 generated)
Dan Beam
5 years, 4 months ago (2015-08-17 23:22:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294253003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294253003/80001
5 years, 4 months ago (2015-08-18 19:16:18 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-18 19:16:20 UTC) #9
Dan Beam
ping michaelpg@ https://codereview.chromium.org/1301723002/ depends on this
5 years, 4 months ago (2015-08-18 19:30:43 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294253003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294253003/80001
5 years, 4 months ago (2015-08-18 19:46:04 UTC) #12
michaelpg
lgtm https://codereview.chromium.org/1294253003/diff/80001/ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css File ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css (right): https://codereview.chromium.org/1294253003/diff/80001/ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css#newcode27 ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css:27: min-width: auto; /* HACK(dbeam): mixins can't be redefined. ...
5 years, 4 months ago (2015-08-18 19:47:06 UTC) #13
Dan Beam
https://codereview.chromium.org/1294253003/diff/80001/ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css File ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css (right): https://codereview.chromium.org/1294253003/diff/80001/ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css#newcode27 ui/webui/resources/cr_elements/v1_0/cr_button/cr_button.css:27: min-width: auto; /* HACK(dbeam): mixins can't be redefined. */ ...
5 years, 4 months ago (2015-08-18 19:51:12 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 20:18:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294253003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294253003/80001
5 years, 4 months ago (2015-08-18 20:32:02 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 4 months ago (2015-08-18 20:37:28 UTC) #19
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 20:38:13 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bebbc793a786a72b55856f38843548a6724b84cb
Cr-Commit-Position: refs/heads/master@{#344020}

Powered by Google App Engine
This is Rietveld 408576698