Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1287713002: [MD settings] merge polymer 1.0.11; hack for settings checkbox (Closed)

Created:
5 years, 4 months ago by dschuyler
Modified:
5 years, 4 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, dcheng, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] merge polymer 1.0.11; hack for settings checkbox This is a bower update of Polymer with the current bower.json settings. I'd like to change the bower.json settings to bring in more polymer elements. As a precursor to that, this CL brings the current Polymer elements up to date (without adding more elements). While doing some brief testing, I found that the paper-checkbox had changed in a way the broke the settings-checkbox. It looks like the settings-checkbox should be updated/changed to cope, but that is beyond the scope of this CL. This CL includes a small hack to fix the settings checkbox along with comments/notes about the hack and what to do to remove the hack. BUG=425627 Committed: https://crrev.com/3f83fc6547344d0517a3d0c45acb85868f0a6fd9 Cr-Commit-Position: refs/heads/master@{#342943}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1688 lines, -1418 lines) Patch
M chrome/browser/resources/settings/checkbox/checkbox.js View 1 chunk +9 lines, -0 lines 1 comment Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/README.md View 1 chunk +2 lines, -14 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/hero.svg View 1 chunk +33 lines, -33 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea.html View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea-extracted.js View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/iron-button-state-extracted.js View 7 chunks +29 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/iron-control-state-extracted.js View 4 chunks +2 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/hero.svg View 1 chunk +23 lines, -23 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js View 4 chunks +20 lines, -18 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/.bower.json View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js View 6 chunks +29 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-scroll-manager-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-fit-behavior/iron-fit-behavior-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-flex-layout/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-flex-layout/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-flex-layout/iron-flex-layout.html View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/.bower.json View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/bower.json View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/iron-form-element-behavior.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/iron-form-element-behavior-extracted.js View 3 chunks +17 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/hero.svg View 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/iron-icon-extracted.js View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/hero.svg View 1 chunk +35 lines, -35 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-iconset-svg/iron-iconset-svg-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/hero.svg View 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/iron-input-extracted.js View 4 chunks +3 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-media-query/hero.svg View 1 chunk +29 lines, -29 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-media-query/iron-media-query-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menubar-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-meta/hero.svg View 1 chunk +33 lines, -33 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-meta/iron-meta-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-backdrop-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/hero.svg View 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/iron-resizable-behavior-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-selector/iron-multi-selectable-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-selector/iron-selectable-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-selector/iron-selection-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-selector/iron-selector-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/README.md View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/iron-test-helpers-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/iron-validatable-behavior-extracted.js View 2 chunks +28 lines, -15 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/driver-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/driver/hash-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/driver/mock-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/driver/path-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/emitter-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/more-route-context-aware-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/more-route-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/more-route-selection-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/more-route-selector-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/more-route-template-helpers-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/more-routing-config-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/params-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/route-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/routing-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/fade-in-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/fade-out-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/hero-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/opaque-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/reverse-ripple-animation-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/ripple-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-down-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/scale-up-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-left-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-from-right-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-left-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-right-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-up-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/transform-animation-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages-extracted.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-shared-element-animatable-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-shared-element-animation-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-button-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-inky-focus-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-button/paper-button-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox.css View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox-extracted.js View 3 chunks +9 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/hero.svg View 1 chunk +51 lines, -51 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/hero.svg View 1 chunk +58 lines, -58 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-drawer-panel/hero.svg View 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-drawer-panel/paper-drawer-panel-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/paper-fab-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/hero.svg View 1 chunk +38 lines, -38 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/.bower.json View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/bower.json View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/hero.svg View 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html View 2 chunks +15 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-addon-behavior-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js View 4 chunks +35 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html View 7 chunks +40 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container-extracted.js View 5 chunks +15 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-error-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea-extracted.js View 3 chunks +27 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-icon-item-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-body-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/paper-material-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/hero.svg View 1 chunk +39 lines, -39 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-animations-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-extracted.js View 6 chunks +87 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/hero.svg View 1 chunk +35 lines, -35 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/paper-menu-extracted.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/hero.svg View 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/hero.svg View 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.css View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js View 3 chunks +9 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-group/hero.svg View 1 chunk +25 lines, -25 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/hero.svg View 1 chunk +30 lines, -30 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/hero.svg View 1 chunk +20 lines, -20 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.css View 8 chunks +22 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js View 9 chunks +24 lines, -19 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/hero.svg View 1 chunk +27 lines, -27 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner-extracted.js View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/hero.svg View 1 chunk +23 lines, -23 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tab-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tabs-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/hero.svg View 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button.css View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button-extracted.js View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toolbar/paper-toolbar-extracted.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer-externs/.bower.json View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer-externs/polymer.externs.js View 2 chunks +29 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/build.log View 1 chunk +6 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-extracted.js View 35 chunks +210 lines, -93 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-micro-extracted.js View 6 chunks +45 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-mini-extracted.js View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dschuyler
5 years, 4 months ago (2015-08-11 22:28:22 UTC) #2
michaelpg
lgtm
5 years, 4 months ago (2015-08-11 23:30:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287713002/1
5 years, 4 months ago (2015-08-11 23:58:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 00:05:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3f83fc6547344d0517a3d0c45acb85868f0a6fd9 Cr-Commit-Position: refs/heads/master@{#342943}
5 years, 4 months ago (2015-08-12 00:06:48 UTC) #7
stevenjb
5 years, 4 months ago (2015-08-13 21:44:38 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1287713002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/checkbox/checkbox.js (right):

https://codereview.chromium.org/1287713002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/checkbox/checkbox.js:67: },
Is there any reason why this was done here instead of in cr_checkbox.js? That is
broken also.

Powered by Google App Engine
This is Rietveld 408576698