Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296773002: clang/win: Enable -Woverloaded-virtual globally. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable -Woverloaded-virtual globally. Previously, it was only enabled for chromium_code on Windows. BUG=505301 Committed: https://crrev.com/6e4734b82f3fa0ed8fea5365ac92dde7e4c29a4f Cr-Commit-Position: refs/heads/master@{#343979}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : . #

Patch Set 5 : gn too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Nico
5 years, 4 months ago (2015-08-18 01:12:12 UTC) #2
Nico
derp, forgot to land https://chromium-review.googlesource.com/293865 . Pretend that that was in and angle rolled and ...
5 years, 4 months ago (2015-08-18 01:26:37 UTC) #3
Matt Giuca
Also need to update build/config/compiler/BUILD.gn. (Revert the changes in https://codereview.chromium.org/1221333010) Thanks for doing this!
5 years, 4 months ago (2015-08-18 03:03:37 UTC) #4
Nico
Done, thanks. > (Revert the changes in https://codereview.chromium.org/1221333010) Sooo many warnings enabled since then :-)
5 years, 4 months ago (2015-08-18 03:25:38 UTC) #5
Matt Giuca
lgtm
5 years, 4 months ago (2015-08-18 04:25:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296773002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296773002/80001
5 years, 4 months ago (2015-08-18 04:26:41 UTC) #8
Nico
Nono, I need to land that angle change first :-)
5 years, 4 months ago (2015-08-18 04:49:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296773002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296773002/80001
5 years, 4 months ago (2015-08-18 18:38:53 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-18 18:43:44 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 18:44:20 UTC) #16
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/6e4734b82f3fa0ed8fea5365ac92dde7e4c29a4f
Cr-Commit-Position: refs/heads/master@{#343979}

Powered by Google App Engine
This is Rietveld 408576698