Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 1221333010: Removed -Wno-overloaded-virtual warning suppression. (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wno-overloaded-virtual-fixes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed -Wno-overloaded-virtual warning suppression. The suppression is still active for third_party code because quite a lot of third_party breaks this rule. BUG=505301 Committed: https://crrev.com/768f0c0caff783381c7d9884a0f98d726b4bd671 Cr-Commit-Position: refs/heads/master@{#337765}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Update comment to refer to this bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M build/common.gypi View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (2 generated)
Matt Giuca
Blocked on https://codereview.chromium.org/1216013005. As with -Wno-unused-variable, I decided to hold off on fixing third-party for ...
5 years, 5 months ago (2015-07-07 04:43:47 UTC) #2
Nico
This is almost certainly a bug in the third-party code, so I'd rather suppress this ...
5 years, 5 months ago (2015-07-07 04:51:57 UTC) #3
Nico
lgtm with the comment changed to "TODO(that bug number): Move this into individual third-party project ...
5 years, 5 months ago (2015-07-07 04:52:34 UTC) #4
Matt Giuca
Done.
5 years, 5 months ago (2015-07-07 05:31:36 UTC) #5
Nico
lgtm
5 years, 5 months ago (2015-07-07 06:05:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221333010/40001
5 years, 5 months ago (2015-07-08 02:44:41 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-08 03:55:16 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 03:56:15 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/768f0c0caff783381c7d9884a0f98d726b4bd671
Cr-Commit-Position: refs/heads/master@{#337765}

Powered by Google App Engine
This is Rietveld 408576698