build/common.gypi - Issue 1296773002: clang/win: Enable -Woverloaded-virtual globally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1296773002: clang/win: Enable -Woverloaded-virtual globally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn too Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 88045922de33a53680f084cd4a3b796ff1b2bc3e..8c0394bf09d72c1e79b820b18f04d3fd14c3af95 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3143,9 +3143,6 @@

['chromium_code==0', {

'variables': {

'clang_warning_flags': [

- # TODO(mgiuca): Move this suppression into individual third-party

- # libraries as required. http://crbug.com/505301.

- '-Wno-overloaded-virtual',

# TODO(thakis): Move this suppression into individual third-party

# libraries as required. http://crbug.com/505316.

'-Wno-unused-function',

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »