Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1296773002: clang/win: Enable -Woverloaded-virtual globally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn too Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 7a00b9384cf9ad756b5e3bcb9a55cfdfbb6b5898..7febde6b4710c292c213866e78d76fe81e6c926d 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1049,10 +1049,6 @@ config("no_chromium_code") {
if (is_clang) {
cflags += [
- # TODO(mgiuca): Move this suppression into individual third-party
- # libraries as required. http://crbug.com/505301.
- "-Wno-overloaded-virtual",
-
# TODO(thakis): Move this suppression into individual third-party
# libraries as required. http://crbug.com/505316.
"-Wno-unused-function",
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698