Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1295173004: Count usage of reading HTMLInputElement::checked during click event handler. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Count usage of reading HTMLInputElement::checked during click event handler. We have quirk code that |checked| returns new value even before the default action of a click event is executed. It adds some code complexity and produced multiple bugs. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200714

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/forms/BaseCheckableInputType.h View 2 chunks +8 lines, -1 line 0 comments Download
M Source/core/html/forms/BaseCheckableInputType.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/forms/CheckboxInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/forms/RadioInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1298133002 Patch 1

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295173004/1
5 years, 4 months ago (2015-08-18 06:40:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295173004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295173004/20001
5 years, 4 months ago (2015-08-18 06:47:40 UTC) #5
tkent
Keishi, would you review this please?
5 years, 4 months ago (2015-08-18 07:15:42 UTC) #7
keishi
LGTM
5 years, 4 months ago (2015-08-18 07:18:59 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 08:02:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295173004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295173004/20001
5 years, 4 months ago (2015-08-18 08:03:00 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 08:06:31 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200714

Powered by Google App Engine
This is Rietveld 408576698