Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: Source/core/html/forms/BaseCheckableInputType.h

Issue 1295173004: Count usage of reading HTMLInputElement::checked during click event handler. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/BaseCheckableInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/BaseCheckableInputType.h
diff --git a/Source/core/html/forms/BaseCheckableInputType.h b/Source/core/html/forms/BaseCheckableInputType.h
index 27b10ba8157c26e5bfe06afc13557dc7c960c33f..f0f350654875030e2ac7f11c72f76b0f150250cc 100644
--- a/Source/core/html/forms/BaseCheckableInputType.h
+++ b/Source/core/html/forms/BaseCheckableInputType.h
@@ -38,9 +38,15 @@ namespace blink {
// Base of checkbox and radio types.
class BaseCheckableInputType : public InputType {
protected:
- BaseCheckableInputType(HTMLInputElement& element) : InputType(element) { }
+ BaseCheckableInputType(HTMLInputElement& element)
+ : InputType(element)
+ , m_isInClickHandler(false)
+ {
+ }
void handleKeydownEvent(KeyboardEvent*) override;
+ bool m_isInClickHandler;
+
private:
FormControlState saveFormControlState() const final;
void restoreFormControlState(const FormControlState&) final;
@@ -51,6 +57,7 @@ private:
String fallbackValue() const final;
bool storesValueSeparateFromAttribute() final;
void setValue(const String&, bool, TextFieldEventBehavior) final;
+ void readingChecked() const final;
bool isCheckable() final;
bool shouldDispatchFormControlChangeEvent(String&, String&) override;
};
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/BaseCheckableInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698