Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1298133002: Convert radio_checked_dynamic.html to the testharness style. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Convert radio_checked_dynamic.html to the testharness style. The test had flaky whitespace error. This CL will fix it. BUG=521854 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -77 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/radio/radio_checked_dynamic.html View 2 chunks +57 lines, -61 lines 0 comments Download
D LayoutTests/fast/forms/radio/radio_checked_dynamic-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
tkent
yosin@, please review this. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast/forms/radio/radio_checked_dynamic.html
5 years, 4 months ago (2015-08-18 08:52:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298133002/1
5 years, 4 months ago (2015-08-18 08:59:22 UTC) #4
yosin_UTC9
lgtm Thanks for reducing size of repository! Do we want to convert all tests? Just ...
5 years, 4 months ago (2015-08-18 09:35:31 UTC) #5
tkent
On 2015/08/18 09:35:31, Yosi_UTC9 wrote: > lgtm > > Thanks for reducing size of repository! ...
5 years, 4 months ago (2015-08-18 09:44:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298133002/1
5 years, 4 months ago (2015-08-18 10:29:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94540)
5 years, 4 months ago (2015-08-18 12:08:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298133002/1
5 years, 4 months ago (2015-08-18 12:13:06 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 14:31:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200727

Powered by Google App Engine
This is Rietveld 408576698