Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: Source/core/html/forms/CheckboxInputType.cpp

Issue 1295173004: Count usage of reading HTMLInputElement::checked during click event handler. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/forms/BaseCheckableInputType.cpp ('k') | Source/core/html/forms/InputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/CheckboxInputType.cpp
diff --git a/Source/core/html/forms/CheckboxInputType.cpp b/Source/core/html/forms/CheckboxInputType.cpp
index b6a4d57a2aef6acda04cac81be90aadcb364c730..2be0d9608d086caf5c0fbfb318c8b87ee08f9411 100644
--- a/Source/core/html/forms/CheckboxInputType.cpp
+++ b/Source/core/html/forms/CheckboxInputType.cpp
@@ -82,7 +82,7 @@ PassOwnPtrWillBeRawPtr<ClickHandlingState> CheckboxInputType::willDispatchClick(
element().setIndeterminate(false);
element().setChecked(!state->checked, DispatchChangeEvent);
-
+ m_isInClickHandler = true;
return state.release();
}
@@ -94,7 +94,7 @@ void CheckboxInputType::didDispatchClick(Event* event, const ClickHandlingState&
} else {
element().dispatchChangeEventIfNeeded();
}
-
+ m_isInClickHandler = false;
// The work we did in willDispatchClick was default handling.
event->setDefaultHandled();
}
« no previous file with comments | « Source/core/html/forms/BaseCheckableInputType.cpp ('k') | Source/core/html/forms/InputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698