Merge to XFA: Extern in .cpp file is a code smell, part 2.

Merge to XFA: Extern in .cpp file is a code smell, part 2.

(cherry picked from commit c3f4894a6862c74b9ab32b4ec38c531de6ecd83c)
Original Review URL: https://codereview.chromium.org/1298393003 .

Fixed IWYU in core/src/fpdftext/text_int.h exposed by new inclusion.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/5417f067844892644486d7b0581c247904059a88

[Tom Sepez, 2015-08-19 20:55:38]

Lei, please check as there was a compilation issue:
core/src/fpdftext/text_int.h:121:16: error: ‘IFX_BidiChar’ has not been declared
   void OnPiece(IFX_BidiChar* pBidi, CFX_WideString& str);

I know you made some changes here recently, want to be sure I didn't undo
anything.

[Lei Zhang, 2015-08-19 20:58:14]

On 2015/08/19 20:55:38, Tom Sepez (Out Aug 20-29) wrote:
> Lei, please check as there was a compilation issue:
> core/src/fpdftext/text_int.h:121:16: error: ‘IFX_BidiChar’ has not been
declared
>    void OnPiece(IFX_BidiChar* pBidi, CFX_WideString& str);
> 
> I know you made some changes here recently, want to be sure I didn't undo
> anything.

The Bidi CL requires a bit of work to merge and I haven't gotten around to
breaking it up into more easier to review CLs yet.

[Lei Zhang, 2015-08-19 20:59:30]

Are there any files I should look at in particular or was this a clean merge?

https://codereview.chromium.org/1294933008/diff/20001/core/src/fpdftext/text_...
File core/src/fpdftext/text_int.h (right):

https://codereview.chromium.org/1294933008/diff/20001/core/src/fpdftext/text_...
core/src/fpdftext/text_int.h:11: #include "../../include/fxcrt/fx_arb.h"
Don't worry about this. I'll fix it when I merge the bidi CL.

[Tom Sepez, 2015-08-19 21:01:41]

On 2015/08/19 20:59:30, Lei Zhang wrote:
> Are there any files I should look at in particular or was this a clean merge?
> 
>
https://codereview.chromium.org/1294933008/diff/20001/core/src/fpdftext/text_...
> File core/src/fpdftext/text_int.h (right):
> 
>
https://codereview.chromium.org/1294933008/diff/20001/core/src/fpdftext/text_...
> core/src/fpdftext/text_int.h:11: #include "../../include/fxcrt/fx_arb.h"
> Don't worry about this. I'll fix it when I merge the bidi CL.
Sorry:

#	both modified:   core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp
#	both modified:   core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
#	both modified:   core/src/fxge/ge/fx_ge_font.cpp
#

[Lei Zhang, 2015-08-19 21:06:47]

lgtm

[Tom Sepez, 2015-08-19 21:13:39]

Committed patchset #2 (id:20001) manually as
5417f067844892644486d7b0581c247904059a88 (presubmit successful).