core/src/fxge/dib/fx_dib_engine.cpp - Issue 1294933008: Merge to XFA: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/dib/fx_dib_engine.cpp

Issue 1294933008: Merge to XFA: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: IWYU Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/dib/fx_dib_engine.cpp

diff --git a/core/src/fxge/dib/fx_dib_engine.cpp b/core/src/fxge/dib/fx_dib_engine.cpp

index b2da83a802d0bbcc0e9d76e90bc5f74ea4fb8a4f..33c033378817232c40a85831996037bb85e0134e 100644

--- a/core/src/fxge/dib/fx_dib_engine.cpp

+++ b/core/src/fxge/dib/fx_dib_engine.cpp

@@ -4,11 +4,12 @@

+#include <limits.h>

#include "../../../include/fxge/fx_dib.h"

#include "../../../include/fxge/fx_ge.h"

#include "dib_int.h"

-#include <limits.h>

-extern int SDP_Table[513];

void CWeightTable::Calc(int dest_len,

int dest_min,

int dest_max,